Skip to content

Commit fe41bbd

Browse files
authored
test: enable videos on tracing bots (#3930)
1 parent e15ac44 commit fe41bbd

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

.github/workflows/tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ jobs:
207207
# XVFB-RUN merges both STDOUT and STDERR, whereas we need only STDERR
208208
# Wrap `npm run` in a subshell to redirect STDERR to file.
209209
# Enable core dumps in the subshell.
210-
- run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- bash -c "ulimit -c unlimited && npx test-runner test/ --jobs=1 --forbid-only --timeout=30000 --global-timeout=5400000 --retries=3 --reporter=dot,json"
210+
- run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- bash -c "ulimit -c unlimited && npx test-runner test/ --jobs=1 --forbid-only --timeout=60000 --global-timeout=5400000 --retries=3 --reporter=dot,json"
211211
env:
212212
BROWSER: ${{ matrix.browser }}
213213
TRACING: true

test/playwright.fixtures.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -278,9 +278,7 @@ defineTestFixture('context', async ({ browser, testOutputDir, testConfig }, runT
278278
const contextOptions: BrowserContextOptions = {
279279
relativeArtifactsPath: path.relative(testConfig.outputDir, testOutputDir),
280280
recordTrace: !!options.TRACING,
281-
// TODO: enable videos. Currently, long videos are slowly processed by Chromium
282-
// and (sometimes) Firefox, which causes test timeouts.
283-
// recordVideos: !!options.TRACING,
281+
recordVideos: !!options.TRACING,
284282
};
285283
const context = await browser.newContext(contextOptions);
286284
await runTest(context);

0 commit comments

Comments
 (0)