oops

Author: DonJayamanne

.github/workflows/pr-check.yml

@@ -16,27 +16,30 @@ on:
 
 jobs:
   tests:
+    # Very generic tests, we don't verify whether the envs are discovered correctly or not.
+    # However we do ensure that envs that are discovered are valid.
+    # See other jobs for specific tests.
     name: Tests
     runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false
       matrix:
         include:
-          # - os: windows-latest
-          #   target: x86_64-pc-windows-msvc
-          #   run_cli: "yes"
-          # - os: windows-latest
-          #   target: aarch64-pc-windows-msvc
-          #   run_cli: "no"
+          - os: windows-latest
+            target: x86_64-pc-windows-msvc
+            run_cli: "yes"
+          - os: windows-latest
+            target: aarch64-pc-windows-msvc
+            run_cli: "no"
           - os: ubuntu-latest
             target: x86_64-unknown-linux-musl
             run_cli: "yes"
-          # - os: macos-latest
-          #   target: x86_64-apple-darwin
-          #   run_cli: "yes"
-          # - os: macos-14
-          #   target: aarch64-apple-darwin
-          #   run_cli: "yes"
+          - os: macos-latest
+            target: x86_64-apple-darwin
+            run_cli: "yes"
+          - os: macos-14
+            target: aarch64-apple-darwin
+            run_cli: "yes"
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -190,7 +193,10 @@ jobs:
           RUST_LOG: trace
         shell: bash
 
-  specific-tests:
+  isolated-tests:
+    # Some of these tests are very specific and need to be run in isolation.
+    # E.g. we need to ensure we have a poetry project setup correctly (without .venv created using `pip -m venv .venv`).
+    # We can try to use the previous `tests` job, but that gets very complicated.
     name: Other Tests
     runs-on: ${{ matrix.os }}
     strategy:
@@ -317,6 +323,8 @@ jobs:
         shell: bash
 
   container-tests:
+    # These tests are required as its not easy/possible to use the previous jobs.
+    # E.g. we need to test against the jupyter container, as we found some issues specific to that env.
     name: Tests in Containers
     container:
       image: ${{ matrix.image }}
@@ -365,60 +373,60 @@ jobs:
         run: cargo test --frozen --features ${{ matrix.feature }} -- --nocapture
         shell: bash
 
-  # builds:
-  #   name: Builds
-  #   runs-on: ${{ matrix.os }}
-  #   strategy:
-  #     fail-fast: false
-  #     matrix:
-  #       include:
-  #         - os: windows-latest
-  #           target: x86_64-pc-windows-msvc
-  #         - os: windows-latest
-  #           target: aarch64-pc-windows-msvc
-  #         - os: ubuntu-latest
-  #           target: x86_64-unknown-linux-musl
-  #           run_cli: "yes"
-  #         #   - os: ubuntu-latest
-  #         #     target: aarch64-unknown-linux-gnu
-  #         #   - os: ubuntu-latest
-  #         #     target: arm-unknown-linux-gnueabihf
-  #         - os: macos-latest
-  #           target: x86_64-apple-darwin
-  #           run_cli: "yes"
-  #         - os: macos-14
-  #           target: aarch64-apple-darwin
-  #           run_cli: "yes"
-  #         #   - os: ubuntu-latest
-  #         #     target: x86_64-unknown-linux-gnu
-  #         #   - os: ubuntu-latest
-  #         #     target: aarch64-unknown-linux-musl
-  #   steps:
-  #     - name: Checkout
-  #       uses: actions/checkout@v4
-
-  #     - name: Rust Tool Chain setup
-  #       uses: dtolnay/rust-toolchain@stable
-  #       with:
-  #         toolchain: stable
-  #         targets: ${{ matrix.target }}
-
-  #     - name: Cargo Fetch
-  #       run: cargo fetch
-  #       shell: bash
-
-  #     - name: Run Tests
-  #       # We do not want to run all features, CI is only for tests with Python
-  #       # Thats a separate job.
-  #       run: cargo test --frozen
-  #       shell: bash
-
-  #     - name: Build
-  #       run: cargo build --release --target ${{ matrix.target }}
-  #       shell: bash
-
-  #     - name: Upload Artifact
-  #       uses: actions/upload-artifact@v4
-  #       with:
-  #         name: pet-${{ matrix.target }}
-  #         path: target/${{ matrix.target }}/release/pet*
+  builds:
+    name: Builds
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - os: windows-latest
+            target: x86_64-pc-windows-msvc
+          - os: windows-latest
+            target: aarch64-pc-windows-msvc
+          - os: ubuntu-latest
+            target: x86_64-unknown-linux-musl
+            run_cli: "yes"
+          #   - os: ubuntu-latest
+          #     target: aarch64-unknown-linux-gnu
+          #   - os: ubuntu-latest
+          #     target: arm-unknown-linux-gnueabihf
+          - os: macos-latest
+            target: x86_64-apple-darwin
+            run_cli: "yes"
+          - os: macos-14
+            target: aarch64-apple-darwin
+            run_cli: "yes"
+          #   - os: ubuntu-latest
+          #     target: x86_64-unknown-linux-gnu
+          #   - os: ubuntu-latest
+          #     target: aarch64-unknown-linux-musl
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Rust Tool Chain setup
+        uses: dtolnay/rust-toolchain@stable
+        with:
+          toolchain: stable
+          targets: ${{ matrix.target }}
+
+      - name: Cargo Fetch
+        run: cargo fetch
+        shell: bash
+
+      - name: Run Tests
+        # We do not want to run all features, CI is only for tests with Python
+        # Thats a separate job.
+        run: cargo test --frozen
+        shell: bash
+
+      - name: Build
+        run: cargo build --release --target ${{ matrix.target }}
+        shell: bash
+
+      - name: Upload Artifact
+        uses: actions/upload-artifact@v4
+        with:
+          name: pet-${{ matrix.target }}
+          path: target/${{ matrix.target }}/release/pet*