Turn off path watcher by default (#1841)

* Remove stale reference

* Don't suppress LHS diagnostics on augmented assign

* Revert "Don't suppress LHS diagnostics on augmented assign"

This reverts commit 6109ac7.

* Escape [ and ]

* PR feedback

* Turn off file watcher by default

* Update per change to the setting default

(cherry picked from commit 226221e)

Author: Mikhail Arkhipov

TROUBLESHOOTING.md

@@ -86,6 +86,10 @@ fill in the rest of the information. Before the second pass is complete, some in
 will be incomplete, and some warnings about unresolved imports may occur. The analysis is
 complete when the status message (in the bottom bar) disappears.
 
+### Completions do not update and/or import is still being reported as unresolved after `pip install`
+Library search path watching is currently disabled by default in order to mitigate issues reported
+in https://github.com/microsoft/python-language-server/pull/1841. If you require this feature, set
+`"python.analysis.watchSearchPaths": true` in your user settings.
 
 ## Filing an issue
 

src/LanguageServer/Impl/LanguageServer.Configuration.cs

@@ -66,7 +66,7 @@ public async Task DidChangeConfiguration(JToken token, CancellationToken cancell
                 var userConfiguredPaths = GetUserConfiguredPaths(pythonSection);
 
                 HandleUserConfiguredPathsChanges(userConfiguredPaths);
-                HandlePathWatchChanges(GetSetting(analysis, "watchSearchPaths", true));
+                HandlePathWatchChanges(GetSetting(analysis, "watchSearchPaths", false));
                 HandleDiagnosticsChanges(pythonSection, settings);
                 HandleCodeActionsChanges(pythonSection);