Handle enableUnresolvedImportWarning and enableUseBeforeDefWarning options in PLS

Author: AlexanderSher

src/Analysis/Engine/Impl/Definitions/Diagnostic.cs

@@ -48,7 +48,7 @@ public class Diagnostic {
     }
 
     public enum DiagnosticSeverity : int {
-        Unspecified = 0,
+        Suppressed = 0,
         Error = 1,
         Warning = 2,
         Information = 3,

src/Analysis/Engine/Test/LanguageServerTests.cs

@@ -298,7 +298,7 @@ public async Task ParseIndentationDiagnostics() {
                 DiagnosticSeverity.Error,
                 DiagnosticSeverity.Warning,
                 DiagnosticSeverity.Information,
-                DiagnosticSeverity.Unspecified
+                DiagnosticSeverity.Suppressed
             }) {
                 // For now, these options have to be configured directly
                 s.ParseQueue.InconsistentIndentation = tc;
@@ -317,7 +317,7 @@ await s.DidChangeTextDocument(new DidChangeTextDocumentParams {
                 await s.WaitForCompleteAnalysisAsync(CancellationToken.None);
 
                 var messages = GetDiagnostics(diags, mod).ToArray();
-                if (tc == DiagnosticSeverity.Unspecified) {
+                if (tc == DiagnosticSeverity.Suppressed) {
                     messages.Should().BeEmpty();
                 } else {
                     messages.Should().OnlyContain($"{tc};inconsistent whitespace;Python;2;0;1");
@@ -359,7 +359,7 @@ public async Task DiagnosticsSettingChange() {
                 await s.SendDidChangeConfiguration(newSettings);
 
                 await s.WaitForCompleteAnalysisAsync(CancellationToken.None);
-                GetDiagnostics(diags, u).Where(st => !st.StartsWith($"{DiagnosticSeverity.Unspecified}")).Should().BeEmpty();
+                GetDiagnostics(diags, u).Where(st => !st.StartsWith($"{DiagnosticSeverity.Suppressed}")).Should().BeEmpty();
             }
         }
 

src/LanguageServer/Core/Impl/Definitions/ServerSettings.cs

@@ -48,7 +48,7 @@ public void SetErrorSeverityOptions(string[] errors, string[] warnings, string[]
                     _map[x] = DiagnosticSeverity.Error;
                 }
                 foreach (var x in disabled) {
-                    _map[x] = DiagnosticSeverity.Unspecified;
+                    _map[x] = DiagnosticSeverity.Suppressed;
                 }
 
                 this.errors = errors;

src/LanguageServer/Core/Impl/Implementation/DiagnosticsErrorSink.cs

@@ -72,18 +72,18 @@ public void ProcessTaskComment(object sender, CommentEventArgs e) {
 
         internal static DiagnosticSeverity GetSeverity(Severity severity) {
             switch (severity) {
-                case Severity.Ignore: return DiagnosticSeverity.Unspecified;
+                case Severity.Ignore: return DiagnosticSeverity.Suppressed;
                 case Severity.Information: return DiagnosticSeverity.Information;
                 case Severity.Warning: return DiagnosticSeverity.Warning;
                 case Severity.Error: return DiagnosticSeverity.Error;
                 case Severity.FatalError: return DiagnosticSeverity.Error;
-                default: return DiagnosticSeverity.Unspecified;
+                default: return DiagnosticSeverity.Suppressed;
             }
         }
 
         internal static Severity GetSeverity(DiagnosticSeverity severity) {
             switch (severity) {
-                case DiagnosticSeverity.Unspecified: return Severity.Ignore;
+                case DiagnosticSeverity.Suppressed: return Severity.Ignore;
                 case DiagnosticSeverity.Information: return Severity.Information;
                 case DiagnosticSeverity.Warning: return Severity.Warning;
                 case DiagnosticSeverity.Error: return Severity.Error;

src/LanguageServer/Impl/LanguageServer.cs

@@ -423,7 +423,7 @@ private void PublishPendingDiagnostics() {
             foreach (var kvp in list) {
                 var parameters = new PublishDiagnosticsParams {
                     uri = kvp.Key,
-                    diagnostics = kvp.Value.Where(d => d.severity != DiagnosticSeverity.Unspecified).ToArray()
+                    diagnostics = kvp.Value.Where(d => d.severity != DiagnosticSeverity.Suppressed).ToArray()
                 };
                 _rpc.NotifyWithParameterObjectAsync("textDocument/publishDiagnostics", parameters).DoNotWait();
             }

src/PTVS/Microsoft.PythonTools.Analyzer/Impl/Intellisense/AnalysisProtocol.cs

@@ -59,8 +59,6 @@ public sealed class InitializeRequest : Request<InitializeResponse> {
             public bool analyzeAllFiles;
             [JsonProperty(DefaultValueHandling = DefaultValueHandling.Ignore)]
             public bool traceLogging;
-            [JsonProperty(DefaultValueHandling = DefaultValueHandling.Ignore)]
-            public bool liveLinting;
         }
 
         public sealed class InterpreterInfo {
@@ -824,6 +822,8 @@ public sealed class SetAnalysisOptionsRequest : Request<Response> {
 
         public sealed class AnalysisOptions {
             public Severity indentationInconsistencySeverity;
+            public bool enableUnresolvedImportWarning;
+            public bool enableUseBeforeDefWarning;
             public Dictionary<string, DiagnosticSeverity> commentTokens;
             public Dictionary<string, int> analysisLimits;
             public LS.MessageType? traceLevel;

src/PTVS/Microsoft.PythonTools.Analyzer/Impl/Intellisense/OutOfProcProjectAnalyzer.cs

@@ -269,8 +269,7 @@ await _server.Initialize(new LS.InitializeParams {
                     },
                     capabilities = new LS.ClientCapabilities {
                         python = new LS.PythonClientCapabilities {
-                            manualFileLoad = !request.analyzeAllFiles,
-                            liveLinting = request.liveLinting
+                            manualFileLoad = !request.analyzeAllFiles
                         },
                         textDocument = new LS.TextDocumentClientCapabilities {
                             completion = new LS.TextDocumentClientCapabilities.CompletionCapabilities {
@@ -1559,9 +1558,35 @@ private Response SetAnalysisOptions(AP.SetAnalysisOptionsRequest request) {
             _server.ParseQueue.TaskCommentMap = Options.commentTokens;
             _server.Analyzer.SetTypeStubPaths(Options.typeStubPaths ?? Enumerable.Empty<string>());
 
+            SetErrorMessagesSeverity();
+
             return new Response();
         }
 
+        private void SetErrorMessagesSeverity() {
+            var serverSettings = new LS.ServerSettings();
+            var warnings = new List<string>();
+            var disabled = new List<string>();
+
+            if (Options.enableUnresolvedImportWarning) {
+                warnings.Add(ErrorMessages.UnresolvedImportCode);
+            } else {
+                disabled.Add(ErrorMessages.UnresolvedImportCode);
+            }
+
+            if (Options.enableUseBeforeDefWarning) {
+                warnings.Add(ErrorMessages.UseBeforeDefCode);
+            } else {
+                disabled.Add(ErrorMessages.UseBeforeDefCode);
+            }
+
+            serverSettings.analysis.SetErrorSeverityOptions(Array.Empty<string>(), warnings.ToArray(), Array.Empty<string>(), disabled.ToArray());
+
+            _server.DidChangeConfiguration(new LS.DidChangeConfigurationParams {
+                settings = serverSettings
+            }, CancellationToken.None).DoNotWait();
+        }
+
 
         public AP.AnalysisOptions Options { get; set; }
 
@@ -1570,7 +1595,7 @@ private void AnalysisQueue_Complete(object sender, EventArgs e) {
         }
 
         private void OnModulesChanged(object sender, EventArgs args) {
-            _server.DidChangeConfiguration(new LS.DidChangeConfigurationParams(), CancellationToken.None).DoNotWait();
+            _server.ReloadModulesAsync(CancellationToken.None).DoNotWait();
         }
 
         private void OnFileChanged(AP.FileChangedEvent e) {
@@ -1653,7 +1678,7 @@ private void OnPublishDiagnostics(object sender, LS.PublishDiagnosticsEventArgs
                 new AP.DiagnosticsEvent {
                     documentUri = e.uri,
                     version = e._version ?? -1,
-                    diagnostics = e.diagnostics?.ToArray()
+                    diagnostics = e.diagnostics?.Where(d => d.severity != DiagnosticSeverity.Suppressed).ToArray()
                 }
             ).DoNotWait();
         }