Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

MoveClass test fails #117

Closed
MikhailArkhipov opened this issue Sep 20, 2018 · 5 comments
Closed

MoveClass test fails #117

MikhailArkhipov opened this issue Sep 20, 2018 · 5 comments
Labels
bug Something isn't working feature: signatures

Comments

@MikhailArkhipov
Copy link

Incorrect setting of analysis (old version wins) due to threading issues.

@MikhailArkhipov MikhailArkhipov added bug Something isn't working priority:P1 labels Sep 20, 2018
@MikhailArkhipov MikhailArkhipov added this to the Sep 2018 milestone Sep 20, 2018
@MikhailArkhipov MikhailArkhipov self-assigned this Sep 20, 2018
@MikhailArkhipov
Copy link
Author

#93

@MikhailArkhipov
Copy link
Author

Fails again

@AlexanderSher
Copy link
Contributor

Test fails because change bfa142d that has fixed the issue was partially undone. Rescheduling may become infinite on large projects (e.g.: https://github.com/Microsoft/ptvsd)

@MikhailArkhipov
Copy link
Author

Actually, it is unclear if we need this test. In verifies that analyzer collects various signatures of the same function with different parameters from function calls and stores them as overloads. I.e. in

def foo(a, b)

if finds all foo(1, 2) and foo('a', 'b') and presents that function may return string or int. IMO, there is not much value here, signature just shows argument names, there is no need to show all variety of actual calls. For example, C# does not show all possible signatures of

object Some(object o)

calculated from actual types passed to the method.

@MikhailArkhipov MikhailArkhipov removed this from the Oct 2018.2 milestone Oct 17, 2018
@MikhailArkhipov MikhailArkhipov removed their assignment Oct 17, 2018
@MikhailArkhipov
Copy link
Author

N/A with the new code base

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working feature: signatures
Projects
None yet
Development

No branches or pull requests

2 participants