Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Can we add integration tests? #381

Closed
lostmsu opened this issue Nov 12, 2018 · 3 comments
Closed

Can we add integration tests? #381

lostmsu opened this issue Nov 12, 2018 · 3 comments
Labels
duplicate This issue or pull request already exists tech debt test issue

Comments

@lostmsu
Copy link
Contributor

lostmsu commented Nov 12, 2018

Does not seem like its urgent, but running a time-limited analysis on something as big as scikit-learn (see #379) before merging pull requests would alleviate some unnoticed regressions.

@jakebailey
Copy link
Member

You're describing two things:

  • Running automated tests on PRs and such, which is already covered by Set up CI with tests on Windows, Mac and Linux #352, but may need to wait until we simplify things to the point where running the suite doesn't take half an hour.
  • Running tests on big complicated codebases like scikit-learn, which we might not really be able to do either until we remove the slow analyzer either (from experience running it on scikit-learn takes a good 20 minutes even when I do it from /tmp).

@lostmsu
Copy link
Contributor Author

lostmsu commented Nov 12, 2018

@jakebailey I think tests can still be run on scikit-learn, or any other large project as long as they are time- or iteration-limited. E.g. just have AnalyzeQueuedEntries called with a timed cancellation token, or cancel it as soon as, say, 100000 units have been (re-)analyzed. The later option would be more stable.

@MikhailArkhipov
Copy link

To #352

@MikhailArkhipov MikhailArkhipov added duplicate This issue or pull request already exists test issue tech debt labels Jan 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate This issue or pull request already exists tech debt test issue
Projects
None yet
Development

No branches or pull requests

3 participants