Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Completions for Tensorflow 1.12.0 missing #453

Closed
brettcannon opened this issue Dec 3, 2018 · 7 comments
Closed

Completions for Tensorflow 1.12.0 missing #453

brettcannon opened this issue Dec 3, 2018 · 7 comments

Comments

@brettcannon
Copy link
Member

brettcannon commented Dec 3, 2018

microsoft/vscode-python#3515

The OP says Jedi is fine and both Jedi and LS worked fine under 1.11.0.

@jakebailey
Copy link
Member

Seems like we got worse since #285.

@jakebailey
Copy link
Member

I just saw the edit about the version info. If it's actually broken from 1.11 to 1.12, then I would have guessed that there was some code change there which uses some feature we don't completely support.

But looking at their repo, I don't believe that to be the case. There haven't been any changes to the nn module since August, which is before even 1.11 was released.

@jakebailey
Copy link
Member

jakebailey commented Dec 3, 2018

Alex and I checked, and his namespace package stuff fixes it (and likely #285 too). 🎉

@gramster gramster closed this as completed Dec 5, 2018
@ericsnowcurrently
Copy link

Per microsoft/vscode-python#5141, this still seems to be a problem.

@jakebailey
Copy link
Member

jakebailey commented Apr 15, 2019

I fixed this in #881/#886; the stable channel does not have the fix yet. It can be tested in the beta channel (which we will promote soon).

@jakebailey
Copy link
Member

jakebailey commented Apr 15, 2019

image

image

@ericsnowcurrently
Copy link

ah, thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants