No completions for requests.Response type

[qubitron]

A case to test with the new analysis code:

requests.get shows it returns a requests.Response type:

Jedi:

[jakebailey]

With #546:

[qubitron]

Nice! We are picking up more completions, and have different icons for properties vs. functions (content is a property, close is a function).

Curious why cookies/elapsed/encoding show as "ABC" vs. the orange icon shown in Jedi. I'm not sure what the icons mean exactly but we might need to double check we're using the right ones in the right places.

[jakebailey]

It's just a completion item kind choice which we'd change to match the old LS. In typeshed:

class Response: # truncated
    encoding = ...  # type: str
    cookies = ...  # type: RequestsCookieJar
    elapsed = ...  # type: datetime.timedelta
    def iter_content(self, chunk_size: Optional[int] = ...,
                     decode_unicode: bool = ...) -> Iterator[Any]: ...
    def iter_lines(self, chunk_size=..., decode_unicode=..., delimiter=...): ...
    @property
    def content(self) -> bytes: ...
    @property
    def text(self) -> str: ...

The wrench is the VSC icon for property.

[jakebailey]

Though this unfortunately shows that we need to parse out those type comments to fully support the requests hints.

[MikhailArkhipov]

#7 currently not GA but can be.

[qubitron]

We may not need to block GA on the type hints, but should probably add support for them soon after.