Merge pull request #3074 from samisayegh/master

[api-extractor-model] Remove "const" keyword before enum to use with typescript isolatedModules

Author: iclanton

apps/api-extractor-model/src/items/ApiItem.ts

@@ -15,7 +15,7 @@ import { ApiItemContainerMixin } from '../mixins/ApiItemContainerMixin';
  *
  * @public
  */
-export const enum ApiItemKind {
+export enum ApiItemKind {
   CallSignature = 'CallSignature',
   Class = 'Class',
   Constructor = 'Constructor',

apps/api-extractor-model/src/mixins/Excerpt.ts

@@ -5,7 +5,7 @@ import { DeclarationReference } from '@microsoft/tsdoc/lib-commonjs/beta/Declara
 import { Text } from '@rushstack/node-core-library';
 
 /** @public */
-export const enum ExcerptTokenKind {
+export enum ExcerptTokenKind {
   /**
    * Generic text without any special properties
    */

common/changes/@microsoft/api-extractor-model/master_2021-12-06-21-04.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/api-extractor-model",
+      "comment": "Replace const enums with conventional enums to allow for compatibility with JavaScript consumers.",
+      "type": "minor"
+    }
+  ],
+  "packageName": "@microsoft/api-extractor-model"
+}

common/reviews/api/api-extractor-model.api.md

@@ -23,7 +23,7 @@ export class AedocDefinitions {
     static readonly preapprovedTag: TSDocTagDefinition;
     // (undocumented)
     static get tsdocConfiguration(): TSDocConfiguration;
-    }
+}
 
 // Warning: (ae-forgotten-export) The symbol "ApiCallSignature_base" needs to be exported by the entry point index.d.ts
 //
@@ -122,7 +122,7 @@ export class ApiDocumentedItem extends ApiItem {
     serializeInto(jsonObject: Partial<IApiDocumentedItemJson>): void;
     // (undocumented)
     get tsdocComment(): tsdoc.DocComment | undefined;
-    }
+}
 
 // Warning: (ae-forgotten-export) The symbol "ApiEntryPoint_base" needs to be exported by the entry point index.d.ts
 //
@@ -284,7 +284,7 @@ export namespace ApiItemContainerMixin {
 }
 
 // @public
-export const enum ApiItemKind {
+export enum ApiItemKind {
     // (undocumented)
     CallSignature = "CallSignature",
     // (undocumented)
@@ -446,7 +446,7 @@ export class ApiPackage extends ApiPackage_base {
     // (undocumented)
     saveToJsonFile(apiJsonFilename: string, options?: IApiPackageSaveOptions): void;
     get tsdocConfiguration(): TSDocConfiguration;
-    }
+}
 
 // @public
 export function ApiParameterListMixin<TBaseClass extends IApiItemConstructor>(baseClass: TBaseClass): TBaseClass & (new (...args: any[]) => ApiParameterListMixin);
@@ -632,10 +632,10 @@ export class ExcerptToken {
     get canonicalReference(): DeclarationReference | undefined;
     get kind(): ExcerptTokenKind;
     get text(): string;
-    }
+}
 
 // @public (undocumented)
-export const enum ExcerptTokenKind {
+export enum ExcerptTokenKind {
     Content = "Content",
     Reference = "Reference"
 }
@@ -914,5 +914,4 @@ export class TypeParameter {
     get tsdocTypeParamBlock(): tsdoc.DocParamBlock | undefined;
 }
 
-
 ```