Merge pull request #138 IsFileSystemSupported: cleanup test files on Mac

IsFileSystemSupported: cleanup test files on Mac

Author: wilbaker

Scalar.FunctionalTests/Tests/EnlistmentPerFixture/CloneTests.cs

@@ -106,6 +106,24 @@ public void CloneToPathWithSpaces()
             enlistment.UnmountAndDeleteAll();
         }
 
+        [TestCase]
+        public void CloneCreatesCorrectFilesInRoot()
+        {
+            ScalarFunctionalTestEnlistment enlistment = ScalarFunctionalTestEnlistment.CloneAndMount(ScalarTestConfig.PathToScalar);
+            try
+            {
+                Directory.GetFiles(enlistment.EnlistmentRoot).ShouldBeEmpty("There should be no files in the enlistment root after cloning");
+                string[] directories = Directory.GetDirectories(enlistment.EnlistmentRoot);
+                directories.Length.ShouldEqual(2);
+                directories.ShouldContain(x => Path.GetFileName(x).Equals(".scalar", StringComparison.Ordinal));
+                directories.ShouldContain(x => Path.GetFileName(x).Equals("src", StringComparison.Ordinal));
+            }
+            finally
+            {
+                enlistment.UnmountAndDeleteAll();
+            }
+        }
+
         private void SubfolderCloneShouldFail()
         {
             ProcessStartInfo processInfo = new ProcessStartInfo(ScalarTestConfig.PathToScalar);

Scalar.Platform.Mac/MacFileSystem.cs

@@ -27,20 +27,20 @@ public override bool IsSocket(string fileName)
 
         public override bool IsFileSystemSupported(string path, out string error)
         {
-            string lowerCaseFile = Guid.NewGuid().ToString().ToLower();
-            string upperCaseFile = lowerCaseFile.ToUpper();
             error = null;
-
             try
             {
-                File.Create(Path.Combine(path, lowerCaseFile));
-                if (File.Exists(Path.Combine(path, upperCaseFile)))
+                string lowerCaseFilePath = Path.Combine(path, $"casetest{Guid.NewGuid().ToString()}");
+                string upperCaseFilePath = lowerCaseFilePath.ToUpper();
+
+                File.Create(lowerCaseFilePath);
+                if (File.Exists(upperCaseFilePath))
                 {
-                    File.Delete(lowerCaseFile);
+                    File.Delete(lowerCaseFilePath);
                     return true;
                 }
 
-                File.Delete(lowerCaseFile);
+                File.Delete(lowerCaseFilePath);
                 error = "Scalar does not support case sensitive filesystems";
                 return false;
             }