Can't install Scalar in a tmux window because /usr/bin/logname returns root

[marcodejongh]

Should the CURRENT_USER variable in the install script use whoami instead of /usr/bin/logname ?

When using tmux whoami returns my username, but /usr/bin/logname returns root.

mdejongh@hostname|~
) /usr/bin/logname
root
mdejongh@hostname|~
) whoami
mdejongh
mdejongh@hostname|~
) echo $LOGNAME
mdejongh
mdejongh@hostname|~
) ps aux | grep zsh
mdejongh         97863   0.0  0.0  4608644   3676 s007  Ss   10:50am   0:00.28 -zsh
mdejongh         32235   0.0  0.0  4764448   1284 s006  Ss   10:15pm   0:00.34 -zsh
mdejongh         22210   0.0  0.0  5026436   1152 s005  Ss+  Sun11pm   0:00.29 -zsh
mdejongh          5064   0.0  0.0  4895600   1328 s003  Ss+  13Feb20   0:00.86 -zsh
mdejongh          4781   0.0  0.0  5289776   3652 s002  Ss+  13Feb20   0:04.59 -zsh
mdejongh          4500   0.0  0.0  5419824   1340 s001  Ss+  13Feb20   0:03.49 -zsh
mdejongh          3808   0.0  0.0  5157508   1084 s000  Ss   13Feb20   0:00.26 /bin/zsh
mdejongh         48276   0.0  0.0  4399328    728 s007  S+   11:38am   0:00.00 grep --color=auto zsh
mdejongh@hostname|~
) ps aux | grep tmux
mdejongh          4199   0.2  0.0  5947672  16008   ??  Ss   13Feb20  63:39.95 tmux -u
mdejongh          4197   0.0  0.0  4550936    672 s000  S+   13Feb20   0:00.03 tmux -u
mdejongh         48435   0.0  0.0  4399328    728 s007  S+   11:38am   0:00.00 grep --color=auto tmux
mdejongh@hostname|~
)

[jrbriggs]

Seems reasonable! I'd really appreciate a PR for this if you have time to make the change and test it in tmux. Look here:

scalar/Scalar.Installer.Mac/InstallScalar.template.sh

Line 37 in d36ad67

CURRENT_USER=$(/usr/bin/logname)

[derrickstolee]

@marcodejongh: I've tried this myself and do not reproduce the same thing when running tmux on my Mac. How are you starting your tmux? I started in my Terminal app running tmux -u as your ps output is showing.

In particular, whoami and logname both return my username.

The problem that I see is that sudo whoami returns "root" while sudo logname returns my username. If someone runs the installer under sudo, then they will not install it properly for their user if we switch to whoami.

[derrickstolee]

I ended up doing the fallback option, as you suggested. That minimizes our risk here. Thanks for the report!