[Mount Removal] Remove GitObjectsRoot and LocalCacheRoot from RepoMetadata.dat and switch to 'gvfs.sharedCache'#137
Merged
Conversation
Copied changes from derrickstolee:gvfs-helper that updated Scalar verbs to set the object cache in git's config file.
derrickstolee
approved these changes
Oct 1, 2019
Contributor
derrickstolee
left a comment
derrickstolee
left a comment
There was a problem hiding this comment.
If you are doing the cache-server setting in a follow-up, then ignore my one comment. Thanks!
wilbaker
force-pushed
the
use_git_config_for_cache
branch
from
dffd208 to
9dc0a9b
Compare
Member
Author
|
@derrickstolee FYI - I saw from the functional test failures there were a few spots I still need to update in the functional tests. I will push another set of commits once I've fixed that code up. |
wilbaker
force-pushed
the
use_git_config_for_cache
branch
3 times, most recently
from
8ae5e81 to
40da08d
Compare
Update Scalar to depend on the local git config for the git objects root and the local cache root and remove them from RepoMetadata.dat
wilbaker
force-pushed
the
use_git_config_for_cache
branch
from
40da08d to
aa7eaa2
Compare
derrickstolee
approved these changes
Oct 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #133
MountFailsWhenNoGitObjectsRootInRepoMetadatato adjust the git config rather than the RepoMetadata.dat file, although I did not test it as those tests are not currently running and the mount verb will eventually be removed.gvfs.sharedCacherather than from the RepoMetadata file.Changes to additional LocalCacheRoot related code will come in a separate PR