Skip to content

ConfigStep: disable status.submoduleSummary when using GVFS protocol #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
derrickstolee merged 1 commit into from
Jun 4, 2020
Merged

ConfigStep: disable status.submoduleSummary when using GVFS protocol #383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Scalar.Common/Maintenance/ConfigStep.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,15 @@ public bool TrySetConfig(out string error)
{ "status.aheadbehind", "false" },
};

if (this.UseGvfsProtocol.Value)
{
// If a user's global config has "status.submoduleSummary=true", then
// that could slow "git status" significantly here, even though the
// GVFS protocol forbids submodules. Still, disable it optionally in
// case the user really wants it in their local config.
optionalSettings.Add("status.submoduleSummary", "false");
}

if (!this.TrySetConfig(optionalSettings, isRequired: false, out error))
{
error = $"Failed to set some optional settings: {error}";
Expand Down