Fix live output with HotReload#3983
Conversation
|
I would have used the same display as for the regular live output with support for the same options but at least it's fixing the hot reload experience so that's good step forward. |
|
This is using the same display as the normal logger with all the options it has. User can suppress the progress for example by calling with --no-progress. The special methods for hot reload call to the same api as normal run. We just need to NOT call the final completion because user would see Aborted message on ctrl_C and that looked ugly and unexpected. |
|
@nohwnd do we see the passed tests by default or is it just you have enabled the detailed output for the gif? I'd really want for the various modes to have the same view by default to provide consistent experience. |
Evangelink
left a comment
Evangelink
left a comment
There was a problem hiding this comment.
Branch is not ready for the next iteration, let's not merge now
|
I think this is also fixing #3831 |
microsoft-github-policy-service
Bot
added
Needs: Attention 👋
and removed
Needs: Author Feedback
labels
|
Yes the default output is to show passed tests in hotReload mode. |
Yes, true. Adding to auto-close. |
|
Can we make it to have consistent output in the various mode and don't show passed tests by default (like for a normal run)? |
Evangelink
left a comment
Evangelink
left a comment
There was a problem hiding this comment.
Approving but would love to have the consistent experience.
Evangelink
left a comment
Evangelink
left a comment
There was a problem hiding this comment.
Approving but would love to have the consistent experience.
2 participants
Fix #3831