Simplify app setting visibility toggle - remove complex monkey-patching

Co-authored-by: alexweininger <[email protected]>

Author: Copilot

main.js

@@ -16,10 +16,10 @@ let perfStats = {
 
 Object.defineProperty(exports, "__esModule", { value: true });
 
-const extension = require('./out/src/extension');
+const extension = require('./dist/extension.bundle');
 
 async function activate(ctx) {
-    return await extension.activateInternal(ctx, perfStats, true /* ignoreBundle */);
+    return await extension.activateInternal(ctx, perfStats);
 }
 
 async function deactivate(ctx) {

package.json

@@ -365,19 +365,7 @@
                 "command": "azureFunctions.toggleAppSettingVisibility",
                 "title": "%azureFunctions.toggleAppSettingVisibility%",
                 "category": "Azure Functions",
-                "icon": "$(eye)"
-            },
-            {
-                "command": "azureFunctions.showAppSettingValue",
-                "title": "%azureFunctions.showAppSettingValue%",
-                "category": "Azure Functions",
-                "icon": "$(eye)"
-            },
-            {
-                "command": "azureFunctions.hideAppSettingValue",
-                "title": "%azureFunctions.hideAppSettingValue%",
-                "category": "Azure Functions",
-                "icon": "$(eye-closed)"
+                "icon": "$(eye-watch)"
             },
             {
                 "command": "azureFunctions.uninstallFuncCoreTools",
@@ -729,13 +717,8 @@
                     "group": "1@4"
                 },
                 {
-                    "command": "azureFunctions.showAppSettingValue",
-                    "when": "view =~ /(azureResourceGroups|azureFocusView|azureWorkspace)/ && viewItem =~ /applicationSettingItem.*(azFunc|localSettings).*hidden/",
-                    "group": "inline"
-                },
-                {
-                    "command": "azureFunctions.hideAppSettingValue", 
-                    "when": "view =~ /(azureResourceGroups|azureFocusView|azureWorkspace)/ && viewItem =~ /applicationSettingItem.*(azFunc|localSettings).*visible/",
+                    "command": "azureFunctions.toggleAppSettingVisibility",
+                    "when": "view =~ /(azureResourceGroups|azureFocusView|azureWorkspace)/ && viewItem =~ /applicationSettingItem.*(azFunc|localSettings)/",
                     "group": "inline"
                 },
                 {
@@ -916,14 +899,6 @@
                     "command": "azureFunctions.toggleAppSettingVisibility",
                     "when": "never"
                 },
-                {
-                    "command": "azureFunctions.showAppSettingValue",
-                    "when": "never"
-                },
-                {
-                    "command": "azureFunctions.hideAppSettingValue",
-                    "when": "never"
-                },
                 {
                     "command": "azureFunctions.viewProperties",
                     "when": "never"

package.nls.json

@@ -108,9 +108,7 @@
     "azureFunctions.templateSource.default": "Default behavior using the best source available.",
     "azureFunctions.templateSource.staging": "Use the very latest templates from the staging template source.",
     "azureFunctions.templateVersion": "A runtime release version (any runtime) that species which templates will be used rather than the latest templates.  This version will be used for ALL runtimes. (Requires a restart of VS Code to take effect)",
-    "azureFunctions.toggleAppSettingVisibility": "Toggle App Setting Visibility.",
-    "azureFunctions.showAppSettingValue": "Show App Setting Value",
-    "azureFunctions.hideAppSettingValue": "Hide App Setting Value",
+    "azureFunctions.toggleAppSettingVisibility": "Toggle App Setting Value Visibility",
     "azureFunctions.uninstallFuncCoreTools": "Uninstall Azure Functions Core Tools",
     "azureFunctions.validateFuncCoreTools": "Validate the Azure Functions Core Tools is installed before debugging.",
     "azureFunctions.viewCommitInGitHub": "View Commit in GitHub",

src/commands/registerCommands.ts

@@ -171,46 +171,13 @@ export function registerCommands(
     registerCommandWithTreeNodeUnwrapping('azureFunctions.stopFunctionApp', stopFunctionApp);
     registerCommandWithTreeNodeUnwrapping('azureFunctions.stopStreamingLogs', stopStreamingLogs);
     registerCommandWithTreeNodeUnwrapping('azureFunctions.swapSlot', swapSlot);
-    // Monkey-patch AppSettingTreeItem to include visibility state in contextValue
-    const originalContextValueGetter = Object.getOwnPropertyDescriptor(AppSettingTreeItem.prototype, 'contextValue')?.get;
-    if (originalContextValueGetter) {
-        Object.defineProperty(AppSettingTreeItem.prototype, 'contextValue', {
-            get: function (this: AppSettingTreeItem) {
-                const originalValue = originalContextValueGetter.call(this) as string;
-                const isHidden = (this.label as string).includes('Hidden value');
-                return isHidden ? `${originalValue};hidden` : `${originalValue};visible`;
-            },
-            configurable: true
-        });
-    }
-
     registerCommandWithTreeNodeUnwrapping(
         'azureFunctions.toggleAppSettingVisibility',
         async (context: IActionContext, node: AppSettingTreeItem) => {
             await node.toggleValueVisibility(context);
         },
         250,
     );
-    registerCommandWithTreeNodeUnwrapping(
-        'azureFunctions.showAppSettingValue',
-        async (context: IActionContext, node: AppSettingTreeItem) => {
-            // Only show if currently hidden
-            if (node.label.includes('Hidden value')) {
-                await node.toggleValueVisibility(context);
-            }
-        },
-        250,
-    );
-    registerCommandWithTreeNodeUnwrapping(
-        'azureFunctions.hideAppSettingValue',
-        async (context: IActionContext, node: AppSettingTreeItem) => {
-            // Only hide if currently shown
-            if (!node.label.includes('Hidden value')) {
-                await node.toggleValueVisibility(context);
-            }
-        },
-        250,
-    );
     registerCommandWithTreeNodeUnwrapping('azureFunctions.uninstallFuncCoreTools', uninstallFuncCoreTools);
     registerCommandWithTreeNodeUnwrapping('azureFunctions.viewCommitInGitHub', viewCommitInGitHub);
     registerSiteCommand('azureFunctions.viewDeploymentLogs', unwrapTreeNodeCommandCallback(viewDeploymentLogs));