Skip to content

Commit 139e71e

Browse files
committed
Fix workspace symbol search regression: restore fast symbol search path for scope::variable queries
The 'fast symbol search' commit (674148f) introduced experimentEnabled to WorkspaceSymbolParams which switches the language server to a faster code path that correctly handles scope::variable queries. A subsequent commit (c3f8d0c) removed this flag as part of cleaning up the experiment, but this caused the server to fall back to the legacy code path that breaks scoped symbol searches (e.g. ns::var returns results for 'ns::' but then fails to return results once any text is typed after '::', breaking all scope::variable searches and Copilot definition lookups for scoped symbols). Fix: restore experimentEnabled: true unconditionally so the working fast code path is always used. Fixes #14200
1 parent 709194d commit 139e71e

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

Extension/src/LanguageServer/Providers/workspaceSymbolProvider.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,8 @@ export class WorkspaceSymbolProvider implements vscode.WorkspaceSymbolProvider {
2222
}
2323

2424
const params: WorkspaceSymbolParams = {
25-
query: query
25+
query: query,
26+
experimentEnabled: true
2627
};
2728

2829
let symbols: LocalizeSymbolInformation[];

Extension/src/LanguageServer/client.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -311,6 +311,7 @@ export interface GetDocumentSymbolRequestParams {
311311

312312
export interface WorkspaceSymbolParams extends WorkspaceFolderParams {
313313
query: string;
314+
experimentEnabled?: boolean;
314315
}
315316

316317
export enum SymbolScope {

0 commit comments

Comments
 (0)