Skip to content

Enable switching between different workspace symbol search implementations using C_Cpp.experimentalFeatures #12448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sean-mcmanus opened this issue Jul 6, 2024 · 2 comments
Closed

Enable switching between different workspace symbol search implementations using C_Cpp.experimentalFeatures #12448

sean-mcmanus opened this issue Jul 6, 2024 · 2 comments
Labels
enhancement Improvement to an existing feature Feature: Symbol Search Language Service more votes needed Issues that have been postponed until more community members upvote it
Milestone
Triage

Comments

@sean-mcmanus
Copy link
Contributor

The different implementations give different fuzzy results and have different performance characteristics.
 
Setting C_Cpp.experimentalFeatures to "enabled" will use the "new" one (which also makes tag parsing faster, fixing #12292).

Setting C_Cpp.experimentalFeatures to "disabled" will use the implementation from 1.19.x.

Setting C_Cpp.experimentalFeatures to "default" will select one for certain users based on whatever the experiment is currently set to.
@sean-mcmanus sean-mcmanus added this to the 1.21.1 milestone Jul 6, 2024
@sean-mcmanus sean-mcmanus self-assigned this Jul 6, 2024
@sean-mcmanus sean-mcmanus mentioned this issue Jul 6, 2024
Closed
@sean-mcmanus sean-mcmanus moved this to Pull Request in cpptools Jul 6, 2024
@heartacker
Copy link

Setting C_Cpp.experimentalFeatures to "enabled" will use the "new" one (which also makes tag parsing faster, fixing #12292).

great /firework

@sean-mcmanus sean-mcmanus removed their assignment Jul 11, 2024
@sean-mcmanus sean-mcmanus removed this from the 1.21.1 milestone Jul 11, 2024
@sean-mcmanus sean-mcmanus moved this from Pull Request to Triage in cpptools Jul 11, 2024
@github-actions GitHub Actions
Copy link

This feature request is being closed due to insufficient upvotes. Please leave a 👍-upvote or 👎-downvote reaction on the issue to help us prioritize it. When enough upvotes are received, this issue will be eligible for our backlog.

@github-actions github-actions bot added the more votes needed Issues that have been postponed until more community members upvote it label Sep 10, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 10, 2024
@github-actions github-actions bot added this to the Triage milestone Sep 10, 2024
@github-project-automation github-project-automation bot moved this from Triage to Done in cpptools Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement to an existing feature Feature: Symbol Search Language Service more votes needed Issues that have been postponed until more community members upvote it
Projects
cpptools
Status: Done
Milestone
Triage
Development

No branches or pull requests
2 participants
@heartacker @sean-mcmanus