Skip to content

Find All References may fail to find references after a rename #12480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sean-mcmanus opened this issue Jul 16, 2024 · 1 comment
Closed

Find All References may fail to find references after a rename #12480

sean-mcmanus opened this issue Jul 16, 2024 · 1 comment
Assignees
@Colengms
Labels
bug Feature: Doc comments An issue related to code comments shown in hover, completion, and signature help. Feature: Find All References Find All References, Peek References, Rename fixed Check the Milestone for the release in which the fix is or will be available. Language Service parser verified Bug has been reproduced
Milestone
1.22.4

Comments

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Jul 16, 2024 •
edited
Loading

  1. Do a Find All Refs (note the number found).
  2. Do a Rename with files.refactoring.autoSave set to false.
  3. Wait for any tag parsing to finish.
  4. Do a Find All Refs on the new name.

Bug: Somewhat randomly, the Find All Refs will be missing results, i.e. the database is not in a valid state and is missing the symbols for certain files. The database appears to become updated/correct after the files with missing references are opened or somehow have their file tag parsed again.

I repro it in 1.20.5 to 1.21.1+.
@sean-mcmanus sean-mcmanus added bug Language Service parser Feature: Doc comments An issue related to code comments shown in hover, completion, and signature help. Feature: Find All References Find All References, Peek References, Rename labels Jul 16, 2024
@bobbrow bobbrow added this to the On Deck milestone Jul 16, 2024
@bobbrow bobbrow moved this to Todo in cpptools Jul 16, 2024
@browntarik browntarik self-assigned this Sep 16, 2024
@browntarik browntarik added the verified Bug has been reproduced label Sep 17, 2024
@sean-mcmanus
Copy link
Contributor Author

@browntarik I still repro this issue.

@Colengms Colengms self-assigned this Sep 18, 2024
@browntarik browntarik removed their assignment Sep 18, 2024
@Colengms Colengms moved this from In progress to Pull Request in cpptools Sep 18, 2024
@Colengms Colengms moved this from Pull Request to Done in cpptools Sep 19, 2024
@Colengms Colengms added the fixed Check the Milestone for the release in which the fix is or will be available. label Sep 19, 2024
@sean-mcmanus sean-mcmanus modified the milestones: On Deck, 1.22.4 Sep 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Colengms Colengms

Labels
bug Feature: Doc comments An issue related to code comments shown in hover, completion, and signature help. Feature: Find All References Find All References, Peek References, Rename fixed Check the Milestone for the release in which the fix is or will be available. Language Service parser verified Bug has been reproduced
Projects
cpptools
Status: Done
Milestone
1.22.4
Development

No branches or pull requests
4 participants
@bobbrow @sean-mcmanus @Colengms @browntarik