Add/fix tests

Author: Kartik Raj

src/client/pythonEnvironments/base/locators/composite/envsCollectionCache.ts

@@ -150,7 +150,7 @@ export class PythonEnvInfoCache extends PythonEnvsWatcher<PythonEnvCollectionCha
     public async clearAndReloadFromStorage(): Promise<void> {
         this.envs = await this.persistentStorage.load();
         this.envs.forEach((e) => {
-            e.hasLatestInfo = false;
+            delete e.hasLatestInfo;
         });
     }
 

src/test/pythonEnvironments/base/locators/composite/envsCollectionService.unit.test.ts

@@ -22,6 +22,7 @@ import {
 } from '../../../../../client/pythonEnvironments/base/locators/composite/envsCollectionCache';
 import { EnvsCollectionService } from '../../../../../client/pythonEnvironments/base/locators/composite/envsCollectionService';
 import { PythonEnvCollectionChangedEvent } from '../../../../../client/pythonEnvironments/base/watcher';
+import * as externalDependencies from '../../../../../client/pythonEnvironments/common/externalDependencies';
 import { noop } from '../../../../core';
 import { TEST_LAYOUT_ROOT } from '../../../common/commonTestConstants';
 import { SimpleLocator } from '../../common';
@@ -546,6 +547,9 @@ suite('Python envs locator - Environments Collection', async () => {
         const resolvedViaLocator = buildEnvInfo({ executable: 'Resolved via locator' });
         const cachedEnvs = getCachedEnvs();
         const env: PythonEnvLatestInfo = cachedEnvs[0];
+        env.executable.ctime = 100;
+        env.executable.mtime = 100;
+        sinon.stub(externalDependencies, 'getFileInfo').resolves({ ctime: 100, mtime: 100 });
         env.hasLatestInfo = true; // Has complete info
         const parentLocator = new SimpleLocator([], {
             resolve: async (e: PythonEnvInfo) => {
@@ -565,6 +569,35 @@ suite('Python envs locator - Environments Collection', async () => {
         sinon.assert.calledOnce(reportInterpretersChangedStub);
     });
 
+    test('resolveEnv() uses underlying locator if cache does not have complete info for env', async () => {
+        const cachedEnvs = getCachedEnvs();
+        const env: PythonEnvLatestInfo = cachedEnvs[0];
+        const resolvedViaLocator = buildEnvInfo({
+            executable: env.executable.filename,
+            sysPrefix: 'Resolved via locator',
+        });
+        env.executable.ctime = 101;
+        env.executable.mtime = 90;
+        sinon.stub(externalDependencies, 'getFileInfo').resolves({ ctime: 100, mtime: 100 });
+        env.hasLatestInfo = true; // Has complete info
+        const parentLocator = new SimpleLocator([], {
+            resolve: async (e: PythonEnvInfo) => {
+                if (env.executable.filename === e.executable.filename) {
+                    return resolvedViaLocator;
+                }
+                return undefined;
+            },
+        });
+        const cache = await createCollectionCache({
+            load: async () => cachedEnvs,
+            store: async () => noop(),
+        });
+        collectionService = new EnvsCollectionService(cache, parentLocator);
+        const resolved = await collectionService.resolveEnv(env.executable.filename);
+        assertEnvEqual(resolved, resolvedViaLocator);
+        sinon.assert.calledOnce(reportInterpretersChangedStub);
+    });
+
     test('resolveEnv() uses underlying locator if cache does not have complete info for env', async () => {
         const resolvedViaLocator = buildEnvInfo({ executable: 'Resolved via locator' });
         const cachedEnvs = getCachedEnvs();