Skip to content

Commit 5fb930d

Browse files
committed
tests - fix bad regex to unblock build
1 parent 1934836 commit 5fb930d

File tree

1 file changed

+4
-4
lines changed
  • src/vs/workbench/contrib/search/common

1 file changed

+4
-4
lines changed

src/vs/workbench/contrib/search/common/search.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ export function getOutOfWorkspaceEditorResources(accessor: ServicesAccessor): UR
103103
}
104104

105105
// Supports patterns of <path><#|:|(><line><#|:|,><col?>
106-
const LINE_COLON_PATTERN = /\s?[#:\(](line )?(?<line>\d*)([#:,](?<col>\d*))?\)?\s*$/;
106+
const LINE_COLON_PATTERN = /\s?[#:\(](?:line )?(\d*)(?:[#:,](\d*))?\)?\s*$/;
107107

108108
export interface IFilterAndRange {
109109
filter: string;
@@ -121,7 +121,7 @@ export function extractRangeFromFilter(filter: string, unless?: string[]): IFilt
121121
const patternMatch = LINE_COLON_PATTERN.exec(filter);
122122

123123
if (patternMatch) {
124-
const startLineNumber = parseInt(patternMatch.groups?.line ?? '', 10);
124+
const startLineNumber = parseInt(patternMatch[1] ?? '', 10);
125125

126126
// Line Number
127127
if (isNumber(startLineNumber)) {
@@ -133,7 +133,7 @@ export function extractRangeFromFilter(filter: string, unless?: string[]): IFilt
133133
};
134134

135135
// Column Number
136-
const startColumn = parseInt(patternMatch.groups?.col ?? '', 10);
136+
const startColumn = parseInt(patternMatch[2] ?? '', 10);
137137
if (isNumber(startColumn)) {
138138
range = {
139139
startLineNumber: range.startLineNumber,
@@ -145,7 +145,7 @@ export function extractRangeFromFilter(filter: string, unless?: string[]): IFilt
145145
}
146146

147147
// User has typed "something:" or "something#" without a line number, in this case treat as start of file
148-
else if (patternMatch.groups?.line === '') {
148+
else if (patternMatch[1] === '') {
149149
range = {
150150
startLineNumber: 1,
151151
startColumn: 1,

0 commit comments

Comments
 (0)