Address review comments.

Author: karthiknadig

src/client/debugger/extension/adapter/logging.ts

@@ -13,12 +13,11 @@ import { StopWatch } from '../../../common/utils/stopWatch';
 import { EXTENSION_ROOT_DIR } from '../../../constants';
 
 class DebugSessionLoggingTracker implements DebugAdapterTracker {
-    private readonly session: DebugSession;
     private readonly enabled: boolean = false;
     private stream: fs.WriteStream | undefined;
     private timer = new StopWatch();
 
-    constructor(session: DebugSession, fileSystem: IFileSystem) {
+    constructor(private readonly session: DebugSession, fileSystem: IFileSystem) {
         this.session = session;
         this.enabled = this.session.configuration.logToFile as boolean;
         if (this.enabled) {
@@ -33,15 +32,15 @@ class DebugSessionLoggingTracker implements DebugAdapterTracker {
     }
 
     public onWillReceiveMessage(message: DebugProtocol.Message) {
-        this.log(`Client <-- Adapter:\n${this.stringify(message)}\n`);
+        this.log(`Client --> Adapter:\n${this.stringify(message)}\n`);
     }
 
     public onDidSendMessage(message: DebugProtocol.Message) {
-        this.log(`Client --> Adapter:\n${this.stringify(message)}\n`);
+        this.log(`Client <-- Adapter:\n${this.stringify(message)}\n`);
     }
 
     public onWillStopSession() {
-        this.log(`Stopping Session\n`);
+        this.log('Stopping Session\n');
     }
 
     public onError(error: Error) {
@@ -65,10 +64,7 @@ class DebugSessionLoggingTracker implements DebugAdapterTracker {
 
 @injectable()
 export class DebugSessionLoggingFactory implements DebugAdapterTrackerFactory {
-    constructor(
-        @inject(IFileSystem) private readonly fileSystem: IFileSystem
-    ) {
-    }
+    constructor(@inject(IFileSystem) private readonly fileSystem: IFileSystem) { }
 
     public createDebugAdapterTracker(session: DebugSession): ProviderResult<DebugAdapterTracker> {
         return new DebugSessionLoggingTracker(session, this.fileSystem);

src/test/debugger/extension/adapter/logging.unit.test.ts

@@ -63,11 +63,11 @@ suite('Debugging - Session Logging', () => {
         public type: string;
         public id: number;
         public format: string;
-        public variables?: { [key: string]: string } | undefined;
-        public sendTelemetry?: boolean | undefined;
-        public showUser?: boolean | undefined;
-        public url?: string | undefined;
-        public urlLabel?: string | undefined;
+        public variables?: { [key: string]: string };
+        public sendTelemetry?: boolean;
+        public showUser?: boolean;
+        public url?: string;
+        public urlLabel?: string;
         constructor(id: number, seq: number, type: string) {
             this.id = id;
             this.format = 'json';