Disable reloading when changing language servers (#18884)

* Remove LSFolderService dependency

* No DI proof of concept

* Add safeguard when connecting/disconnecting

* Proper Pylance LS disposal

* Fix Jedi LS startup/disposal

* Add cache support

* Remove DI decorators + registry activation

* Do not reload window when Pylance not installed

* jedi/pylance/none extension managers

* languageServer/watcher.unit.test.ts

* News entry

* Add 2.7 behaviour + fix linting

* Remove deprecated LS settings

* Add support for 1 LS per workspace folder

* Add tests

* Update src/client/languageServer/watcher.ts

Co-authored-by: Kartik Raj <[email protected]>

* Add resource path to "starting ls" message

* Fix issue with get()

* Amend ILanguageServerExtensionManager comment

Co-authored-by: Kartik Raj <[email protected]>

Author: kimadeline

.eslintignore

@@ -35,10 +35,7 @@ src/test/terminals/codeExecution/terminalCodeExec.unit.test.ts
 src/test/terminals/codeExecution/codeExecutionManager.unit.test.ts
 src/test/terminals/codeExecution/djangoShellCodeExect.unit.test.ts
 
-src/test/activation/activationService.unit.test.ts
 src/test/activation/activeResource.unit.test.ts
-src/test/activation/node/languageServerChangeHandler.unit.test.ts
-src/test/activation/node/activator.unit.test.ts
 src/test/activation/extensionSurvey.unit.test.ts
 
 src/test/utils/fs.ts
@@ -176,18 +173,9 @@ src/client/terminals/codeExecution/djangoContext.ts
 src/client/activation/commands.ts
 src/client/activation/progress.ts
 src/client/activation/extensionSurvey.ts
-src/client/activation/common/languageServerChangeHandler.ts
-src/client/activation/common/activatorBase.ts
 src/client/activation/common/analysisOptions.ts
 src/client/activation/refCountedLanguageServer.ts
 src/client/activation/languageClientMiddleware.ts
-src/client/activation/node/manager.ts
-src/client/activation/node/languageServerProxy.ts
-src/client/activation/node/languageClientFactory.ts
-src/client/activation/node/languageServerFolderService.ts
-src/client/activation/node/analysisOptions.ts
-src/client/activation/node/activator.ts
-src/client/activation/none/activator.ts
 
 src/client/formatters/serviceRegistry.ts
 src/client/formatters/helper.ts

news/1 Enhancements/18509.md

@@ -0,0 +1 @@
+Do not require a reload when swapping between language servers.

package.nls.json

@@ -175,9 +175,9 @@
     "LanguageService.extractionCompletedOutputMessage": "Language server download complete",
     "LanguageService.extractionDoneOutputMessage": "done",
     "LanguageService.reloadVSCodeIfSeachPathHasChanged": "Search paths have changed for this Python interpreter. Please reload the extension to ensure that the IntelliSense works correctly",
-    "LanguageService.startingPylance": "Starting Pylance language server.",
-    "LanguageService.startingJedi": "Starting Jedi language server.",
-    "LanguageService.startingNone": "Editor support is inactive since language server is set to None.",
+    "LanguageService.startingPylance": "Starting Pylance language server for {0}.",
+    "LanguageService.startingJedi": "Starting Jedi language server for {0}.",
+    "LanguageService.startingNone": "Editor support is inactive since language server is set to None for {0}.",
     "LanguageService.reloadAfterLanguageServerChange": "Please reload the window switching between language servers.",
     "AttachProcess.unsupportedOS": "Operating system '{0}' not supported.",
     "AttachProcess.attachTitle": "Attach to process",

resources/report_issue_user_settings.json

@@ -4,7 +4,6 @@
     "onDidChange": false,
     "defaultInterpreterPath": "placeholder",
     "defaultLS": true,
-    "downloadLanguageServer": true,
     "envFile": "placeholder",
     "venvPath": "placeholder",
     "venvFolders": "placeholder",
@@ -14,7 +13,6 @@
     "devOptions": false,
     "disableInstallationChecks": false,
     "globalModuleInstallation": false,
-    "autoUpdateLanguageServer": false,
     "languageServer": true,
     "languageServerIsDefault": false,
     "logging": true,

src/client/activation/activationService.ts

@@ -5,7 +5,6 @@ import { injectable } from 'inversify';
 import { PYLANCE_EXTENSION_ID } from '../../common/constants';
 import { IDefaultLanguageServer, IExtensions, DefaultLSType } from '../../common/types';
 import { IServiceManager } from '../../ioc/types';
-import { ILSExtensionApi } from '../node/languageServerFolderService';
 import { LanguageServerType } from '../types';
 
 @injectable()
@@ -29,7 +28,7 @@ export async function setDefaultLanguageServer(
 }
 
 async function getDefaultLanguageServer(extensions: IExtensions): Promise<DefaultLSType> {
-    if (extensions.getExtension<ILSExtensionApi>(PYLANCE_EXTENSION_ID)) {
+    if (extensions.getExtension(PYLANCE_EXTENSION_ID)) {
         return LanguageServerType.Node;
     }