Skip to content

Commit ce50bd4

Browse files
authored
Remove unused showLocal proposal (#236032)
* Remove unused showLocal proposal * No local build error??
1 parent 4325b8c commit ce50bd4

File tree

5 files changed

+3
-31
lines changed

5 files changed

+3
-31
lines changed

src/vs/platform/extensions/common/extensionsApiProposals.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -319,9 +319,6 @@ const _allApiProposals = {
319319
shareProvider: {
320320
proposal: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.shareProvider.d.ts',
321321
},
322-
showLocal: {
323-
proposal: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.showLocal.d.ts',
324-
},
325322
speech: {
326323
proposal: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.speech.d.ts',
327324
},

src/vs/workbench/api/browser/mainThreadDialogs.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import { URI } from '../../../base/common/uri.js';
77
import { MainThreadDiaglogsShape, MainContext, MainThreadDialogOpenOptions, MainThreadDialogSaveOptions } from '../common/extHost.protocol.js';
88
import { extHostNamedCustomer, IExtHostContext } from '../../services/extensions/common/extHostCustomers.js';
99
import { IFileDialogService, IOpenDialogOptions, ISaveDialogOptions } from '../../../platform/dialogs/common/dialogs.js';
10-
import { Schemas } from '../../../base/common/network.js';
1110

1211
@extHostNamedCustomer(MainContext.MainThreadDialogs)
1312
export class MainThreadDialogs implements MainThreadDiaglogsShape {
@@ -47,7 +46,7 @@ export class MainThreadDialogs implements MainThreadDiaglogsShape {
4746
canSelectMany: options?.canSelectMany,
4847
defaultUri: options?.defaultUri ? URI.revive(options.defaultUri) : undefined,
4948
title: options?.title || undefined,
50-
availableFileSystems: options?.allowUIResources ? [Schemas.vscodeRemote, Schemas.file] : []
49+
availableFileSystems: []
5150
};
5251
if (options?.filters) {
5352
result.filters = [];

src/vs/workbench/api/common/extHost.api.impl.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -781,7 +781,7 @@ export function createApiFactoryAndRegisterActors(accessor: ServicesAccessor): I
781781
return extHostQuickOpen.showInput(options, token);
782782
},
783783
showOpenDialog(options) {
784-
return extHostDialogs.showOpenDialog(extension, options);
784+
return extHostDialogs.showOpenDialog(options);
785785
},
786786
showSaveDialog(options) {
787787
return extHostDialogs.showSaveDialog(options);

src/vs/workbench/api/common/extHostDialogs.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66
import type * as vscode from 'vscode';
77
import { URI } from '../../../base/common/uri.js';
88
import { MainContext, MainThreadDiaglogsShape, IMainContext } from './extHost.protocol.js';
9-
import { checkProposedApiEnabled } from '../../services/extensions/common/extensions.js';
10-
import { IExtensionDescription } from '../../../platform/extensions/common/extensions.js';
119

1210
export class ExtHostDialogs {
1311

@@ -17,10 +15,7 @@ export class ExtHostDialogs {
1715
this._proxy = mainContext.getProxy(MainContext.MainThreadDialogs);
1816
}
1917

20-
showOpenDialog(extension: IExtensionDescription, options?: vscode.OpenDialogOptions): Promise<URI[] | undefined> {
21-
if (options?.allowUIResources) {
22-
checkProposedApiEnabled(extension, 'showLocal');
23-
}
18+
showOpenDialog(options?: vscode.OpenDialogOptions): Promise<URI[] | undefined> {
2419
return this._proxy.$showOpenDialog(options).then(filepaths => {
2520
return filepaths ? filepaths.map(p => URI.revive(p)) : undefined;
2621
});

src/vscode-dts/vscode.proposed.showLocal.d.ts

Lines changed: 0 additions & 19 deletions
This file was deleted.

0 commit comments

Comments
 (0)