Skip to content

Commit ef16727

Browse files
authored
Clean up smoke test requirement (#21729)
Cleaning up smoke test dependency: See if all Github action test pass with removing the smoke test requirement file content. Checked one by one, and came to see removing all doesn't seem to have impact on the outcome of running smoke test.(Seems to have no difference in smoke test result outcome when ran with "Run and Debug" in VS Code with smoke-test option selected). Also got rid of below, after checking smoke test correctly passing after removal of smoke-test-requirement.txt content: ![Screenshot 2023-08-01 at 2 57 45 PM](https://github.com/microsoft/vscode-python/assets/62267334/45d404de-74dd-45a5-885b-71a25ef16ad7) Resolve: #21496
1 parent 358635d commit ef16727

File tree

3 files changed

+0
-13
lines changed

3 files changed

+0
-13
lines changed

.github/actions/smoke-tests/action.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ runs:
2626
cache-dependency-path: |
2727
build/test-requirements.txt
2828
requirements.txt
29-
build/smoke-test-requirements.txt
3029
3130
- name: Install dependencies (npm ci)
3231
run: npm ci --prefer-offline
@@ -43,11 +42,6 @@ runs:
4342
python -m pip --disable-pip-version-check install -t ./pythonFiles/lib/python --implementation py --no-deps --upgrade --pre debugpy
4443
shell: bash
4544

46-
- name: pip install smoke test requirements
47-
run: |
48-
python -m pip install --upgrade -r build/smoke-test-requirements.txt
49-
shell: bash
50-
5145
# Bits from the VSIX are reused by smokeTest.ts to speed things up.
5246
- name: Download VSIX
5347
uses: actions/download-artifact@v2

build/smoke-test-requirements.txt

Lines changed: 0 additions & 6 deletions
This file was deleted.

scripts/onCreateCommand.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ source /workspaces/vscode-python/.venv/bin/activate
2929
npx gulp installPythonLibs
3030

3131
/workspaces/vscode-python/.venv/bin/python -m pip install -r build/test-requirements.txt
32-
/workspaces/vscode-python/.venv/bin/python -m pip install -r build/smoke-test-requirements.txt
3332
/workspaces/vscode-python/.venv/bin/python -m pip install -r build/functional-test-requirements.txt
3433

3534
# Below will crash codespace

0 commit comments

Comments
 (0)