-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Remove component adapter and use the discovery API directly in the extension #14980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Note that this only applies to before the first time we refresh the cache during each session. (Otherwise For the extension the impact is solely during the activation. Furthermore, the caching locator should make this a non-issue, right? So if resolveEnv() is blocking extension activation then either something is wrong with the caching locator or we are trying to resolve an env that isn't already in the cache. In the former case we should fix the locator. In the latter case, we should look at the specific circumstances under which this is a problem and determine if it is a problem in practice. Regardless, we should be sure we have all the details of the situation and decide if it's really necessary before we expand the locator API. I'm not saying something like a "kindOnly" option to |
FWIW, with the planned (slow) move to components, with the corresponding refactoring, I anticipate that eventually there will be nothing in extension activation which env discovery would block. |
Yes, from the initial investigation, this was the cause. env is not stored in cache if running |
resolveEnv()
calls are slowing extension activation.
This could mean that we may need to add an option in the resolveEnv API to query only for kind to handle scenarios like
resolveEnv is much more expensive than just identification.
|
Closing in favor of #20240 (comment). |
From @karrtikr (in an internal work item):
The text was updated successfully, but these errors were encountered: