Skip to content

formatOnType strips spaces around = when used in type hints #1793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brettcannon opened this issue May 29, 2018 · 0 comments · Fixed by #1798
Closed

formatOnType strips spaces around = when used in type hints #1793

brettcannon opened this issue May 29, 2018 · 0 comments · Fixed by #1798
Assignees
@MikhailArkhipov
Labels
area-formatting bug Issue identified by VS Code Team member as probable bug
Milestone
May 2018

Comments

@brettcannon
Copy link
Member 

def munge(input: AnyStr, sep: AnyStr = None, limit=1000): ...

becomes:

def munge(input: AnyStr, sep: AnyStr=None, limit=1000): ...

From PEP 8.
@brettcannon brettcannon added bug Issue identified by VS Code Team member as probable bug needs PR area-formatting labels May 29, 2018
@MikhailArkhipov MikhailArkhipov self-assigned this May 30, 2018
@MikhailArkhipov MikhailArkhipov added this to the May 2018 milestone May 30, 2018
@MikhailArkhipov MikhailArkhipov mentioned this issue May 30, 2018
Merged
4 tasks
@ericsnowcurrently ericsnowcurrently mentioned this issue May 30, 2018
Closed
16 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Jul 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MikhailArkhipov MikhailArkhipov

Labels
area-formatting bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
May 2018
Development

Successfully merging a pull request may close this issue.

Format on type fixes
2 participants
@brettcannon @MikhailArkhipov