Skip to content

Linting with flake8 not working with conda run #18364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
karthiknadig opened this issue Jan 25, 2022 · 6 comments · Fixed by #18390
Closed

Linting with flake8 not working with conda run #18364

karthiknadig opened this issue Jan 25, 2022 · 6 comments · Fixed by #18390
Assignees
@karthiknadig @paulacamargo25
Labels
area-linting bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
January 2022

Comments

@karthiknadig
Copy link
Member

Testing #18349

Pylint works because we don't have to pass formatting. With flake8 it seems to not work at all.
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Jan 25, 2022
@karthiknadig
Copy link
Member Author

karthiknadig commented Jan 25, 2022 •
edited
Loading

from the output here we don't see any thing:
image

If you quote it you might see this (which is wrong as well):
image

@karthiknadig karthiknadig self-assigned this Jan 26, 2022
@karthiknadig karthiknadig added area-linting bug Issue identified by VS Code Team member as probable bug triage and removed triage-needed Needs assignment to the proper sub-team labels Jan 26, 2022
@karthiknadig
Copy link
Member Author

this is caused due to conda/conda#10972

@karthiknadig karthiknadig mentioned this issue Jan 27, 2022
Merged
@karthiknadig karthiknadig added this to the January 2022 milestone Jan 28, 2022
@roblourens
Copy link
Member

How do I do this? I set "python.linting.flake8Enabled": true, and flake8 is not an option for python.formatting.provider. I run "Format Document" and it says it's using autopep8

@roblourens roblourens added the verification-steps-needed Steps to verify are needed for verification label Feb 1, 2022
@karthiknadig
Copy link
Member Author

@roblourens flake8 is not a formatter. You just set it as a linter.

@karthiknadig
Copy link
Member Author

The formatting i mention in the issue is a argument that we used to pass to flake8, to format the output of the text that flake8 printed out.

@roblourens
Copy link
Member

Sorry, reading comprehension fail. I think it is working

@roblourens roblourens added verified Verification succeeded and removed verification-steps-needed Steps to verify are needed for verification labels Feb 1, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karthiknadig karthiknadig

@paulacamargo25 paulacamargo25

Labels
area-linting bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
January 2022
Development

Successfully merging a pull request may close this issue.

Fix linting under conda run karthiknadig/vscode-python
3 participants
@roblourens @karthiknadig @paulacamargo25