Some of the get functions are causing a refresh

[rchiodo]

Testing #18727

I had code like so:

const extension = vscode.extensions.getExtension("ms-python.python");
  if (extension) {
    if (!extension.isActive) {
      await extension.activate();
    }
    const api: IExtensionApi & IProposedExtensionAPI =
      extension.exports as IExtensionApi & IProposedExtensionAPI;
    if (api.environment) {
      api.environment.onDidEnvironmentsChanged(
        onEnvironmentsChanged.bind(undefined, api),
        undefined,
        context.subscriptions
      );
      void api.environment.refreshEnvironment();
    }
  }

And a handler like so:

function onEnvironmentsChanged(api: IExtensionApi & IProposedExtensionAPI) {
  api.environment.getActiveEnvironmentPath(undefined).then((a) => {
    api.environment.getEnvironmentPaths().then(async (p) => {
      console.log(
        `Environment list changed. Active is ${JSON.stringify(
          a
        )}. \n${JSON.stringify(p, undefined, " ")}`
      );
      if (p) {
        p.forEach(async (t) => {
          const details = await api.environment.getEnvironmentDetails(t.path);
          console.log(
            `Environment details for ${t.path} are ${JSON.stringify(
              details,
              undefined,
              " "
            )}`
          );
        });
      }
    });
  });
}

This handler is continually called. One of the functions in it is causing a refresh.

[karrtikr]

Should be fixed by #18766

[rchiodo]

I'm still reproing this. Same exact code with the build from here:
https://github.com/microsoft/vscode-python/actions/runs/2030538168

[karrtikr]

I used the same run (v2022.3.2030538168-dev) but unable to repro this. This is my extension sample: https://github.com/microsoft/vscode-extension-samples/tree/kartik/testbranch/helloworld-sample, & my commit of your handler: microsoft/vscode-extension-samples@8aa5dcc

Not sure what might be going on, for me logging stops once the refresh is over. Let's discuss once you're up.

[rchiodo]

Nope I was wrong. Not infinite anymore, just fires a lot.