Skip to content

Tech debt: Do not expose ILanguageServerExtensionManager outside of the languageServer module #18946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kimadeline opened this issue Apr 18, 2022 · 0 comments · Fixed by #18950
Closed

Tech debt: Do not expose ILanguageServerExtensionManager outside of the languageServer module #18946

kimadeline opened this issue Apr 18, 2022 · 0 comments · Fixed by #18950
Assignees
@karrtikr
Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. good first issue verified Verification succeeded
Milestone
April 2022

Comments

@kimadeline
Copy link

See discussion on https://github.com/microsoft/vscode-python/pull/18884/files#r852332963: ILanguageServerExtensionManager doesn't need to be exposed outside of language server-related classes, however at the moment everything in src/client/languageServer/types.ts can be used anywhere.
@kimadeline kimadeline added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. area-internal Label for non-user facing issues labels Apr 18, 2022
@kimadeline kimadeline mentioned this issue Apr 18, 2022
Merged
@karrtikr karrtikr self-assigned this Apr 18, 2022
@karrtikr karrtikr mentioned this issue Apr 19, 2022
Merged
@karrtikr karrtikr added this to the April 2022 milestone Apr 19, 2022
@karrtikr karrtikr added the verified Verification succeeded label Apr 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karrtikr karrtikr

Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. good first issue verified Verification succeeded
Projects
None yet
Milestone
April 2022
2 participants
@karrtikr @kimadeline