Skip to content

apiTypes.ts should be self contained #19214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rchiodo opened this issue May 31, 2022 · 1 comment
Open

apiTypes.ts should be self contained #19214

rchiodo opened this issue May 31, 2022 · 1 comment
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality needs PR Ready to be worked on

Comments

@rchiodo
Copy link

rchiodo commented May 31, 2022

Testing #19103

It takes a bunch of hunting down types to use the apiTypes.ts file. It would be nice if all the types needed were defined in this one spot.

Examples:

import { IDataViewerDataProvider, IJupyterUriProvider } from './jupyter/types';

@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label May 31, 2022
@karrtikr
Copy link

karrtikr commented Jun 1, 2022

Yes, we plan to publish an npm package for the types.

@karrtikr karrtikr removed their assignment Jun 1, 2022
@karthiknadig karthiknadig added feature-request Request for new features or functionality needs PR area-environments Features relating to handling interpreter environments and removed triage-needed Needs assignment to the proper sub-team labels Jun 1, 2022
@github-actions github-actions bot removed the needs PR label Aug 9, 2022
@karrtikr karrtikr added the needs PR Ready to be worked on label Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality needs PR Ready to be worked on
Projects
None yet
Development

No branches or pull requests

3 participants