Skip to content

Ruff rules to consider adding #23059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brettcannon opened this issue Mar 12, 2024 · 0 comments
Closed

Ruff rules to consider adding #23059

brettcannon opened this issue Mar 12, 2024 · 0 comments
Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. good first issue needs PR Ready to be worked on

Comments

@brettcannon
Copy link
Member

When researching for #22741, these were the original rules I was going to propose. Unfortunately, the amount of work to make the code clean in one go was too much, so I stayed w/ the default set. But it would probably be worth seeing if it was worth adding these rules one at a time.

Ruff defaults to F and a subset of E, so those 2 should at least always be included.

### Tasks
- [ ] `"E4", "E7", "E9",  # pycodestyle`
- [ ] `"I",  # isort`
- [ ] `"N",  # pep8-naming`, ignore N818
- [ ] `"D2", "D400", "D403", "D419",  # pydocstyle`
- [ ] `"UP",  # pyupgrade`
- [ ] `"YTT",  # flake8-2020`
- [ ] `"ASYNC",  # flake8-async`
- [ ] `"B",  # flake8-bugbear`
- [ ] `"A",  # flake8-builtins`
- [ ] `"C",  # flake8-comprehensions`
- [ ] `"DTZ",  # flake8-dasetimez`
- [ ] `"INP",  # flake8-no-pep420`
- [ ] `"PIE",  # flake8-pie`
- [ ] `"PYI",  # flake8-pyi`
- [ ] `"PT006", "PT007", "PT009", "PT012", "PT014", "PT015", "PT016", "PT017", "PT018", "PT019", "PT020", "PT021", "PT022", "PT024", "PT025", "PT026", "PT027",  # flake8-pytest-style`, ignore PT027
- [ ] `"RSE",  # flake8-raise`
- [ ] `"RET502", "RET503", "RET504",  # flake8-return`
- [ ] `"SLF",  # flake8-self`
- [ ] `"SIM",  # flake8-simplify`
- [ ] `"TCH",  # flake8-type-checking`
- [ ] `"ARG",  # flake8-unused-argument`
- [ ] `"PTH",  # flake8-pathlib`, ignore PTH123
- [ ] `"ERA",  # eradicate`
- [ ] `"PD",  # pandas-vet`
- [ ] `"PGH",  # pygrep-hooks`, ignore PGH001
- [ ] `"NPY",  # NymPy-specific rules`
- [ ] `"PERF",  # Perflint`
- [ ] `"RUF",  # Ruff-specific rules`
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Mar 12, 2024
@brettcannon brettcannon added good first issue debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Mar 12, 2024
@karthiknadig karthiknadig added area-internal Label for non-user facing issues needs PR Ready to be worked on and removed triage-needed Needs assignment to the proper sub-team labels Mar 13, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. good first issue needs PR Ready to be worked on
Projects
None yet
Development

No branches or pull requests

2 participants