Skip to content

Task property "presentation": {"reveal": "never"} is not working when Python extension is active #3852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jcrmatos opened this issue Jan 3, 2019 · 6 comments
Assignees

Comments

@jcrmatos
Copy link

jcrmatos commented Jan 3, 2019

Environment data

  • VS Code version: 1.30.1
  • Extension version (available under the Extensions sidebar): 2018.12.1
  • OS and version: Windows 7 Pro SP1 + all updates
  • Python version (& distribution if applicable, e.g. Anaconda): 3.7.1 (WinPython)
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): virtualenv created by pipenv

Expected behaviour

Task property "presentation": {"reveal": "never"} should never show the terminal panel when the task runs.

Actual behaviour

Task property "presentation": {"reveal": "never"} always shows the terminal panel when the task runs and the Python extension is active.

Steps to reproduce:

  1. Activate the Python extension.
  2. Create a task, eg.
        {
            "label": "Py3 Help",
            "type": "shell",
            "windows": {
                "command": "${env:OneDrive}\\Python\\winpython371-32\\python-3.7.1\\Doc\\python371.chm"
            },
            "presentation": {
                "reveal": "never"
            }
        },
  1. Create a keyboard shortcut, eg.
[{
    "key": "shift+f1",
    "command": "workbench.action.tasks.runTask",
    "args": "Py3 Help"
}]
  1. Run the task, in my eg. shift+F1

Output in terminal (that should not appear)

> Executing task in folder uniclave: C:\Users\JMatos\OneDrive\Python\winpython371-32\python-3.7.1\Doc\python371.chm <


Terminal will be reused by tasks, press any key to close it.

I created a simple Task and added the presentation item, hoping that that would allow me to never show the integrated terminal (as it is reported in the doc at
https://code.visualstudio.com/docs/editor/tasks#vscode
but it isn't working. It always shows the integrated terminal.

{
    // See https://go.microsoft.com/fwlink/?LinkId=733558
    // for the documentation about the tasks.json format
    "version": "2.0.0",
    "tasks": [
        {
            "label": "Py3 Help",
            "type": "shell",
            "command": "C:\\Python354-32\\Doc\\python354.chm",
            "problemMatcher": [],
            "presentation": {
                "reveal": "never"
            }
        }
    ]
}

Thanks,

JM

@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Jan 3, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Jan 4, 2019
@d3r3kk d3r3kk closed this as completed Jan 4, 2019
@d3r3kk
Copy link

d3r3kk commented Jan 4, 2019

Issue moved to Microsoft/vscode #66056 via ZenHub

@d3r3kk
Copy link

d3r3kk commented Jan 4, 2019

@DonJayamanne could you have a look at #65179 before we close this one on our repo. It would seem that the integrated terminal only opens when the Python extension is active...

@jcrmatos
Copy link
Author

jcrmatos commented Jan 4, 2019

Hello,

It was me who opened issue #65179 at vscode, but because it only occurs when using the Python extension, I closed it and opened a new issue here.

Thanks,

JM

@d3r3kk
Copy link

d3r3kk commented Jan 4, 2019

because it only occurs when using the Python extension...

Yes, I didn't realize that bit when I closed it! Thanks, we will have a look and see if there is something we are doing on our end.

@DonJayamanne
Copy link

Please add the following setting "python.terminal.activateEnvironment": false in your workspace settings.json file.
This will ensure the terminal doesn't get activated with the workspace virtual environment.

@ghost ghost removed the triage label Jan 8, 2019
@jcrmatos
Copy link
Author

jcrmatos commented Jan 8, 2019

Hello,

I'm sorry but that makes no sense. I want the terminal to activate the venv.

What should not happen is the task to show in terminal if the option

"presentation": {
                "reveal": "never"
            }

is present.

And this only happens with the Python extension activated.
If I disable it everything works.

Thanks,

JM

@lock lock bot locked as resolved and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants