-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Python version indicator should show on the right hand side #5429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Is it documented somewhere what extensions should put it on the right or on the left? We'd like to keep it in the left side since it's workspace related info, while on the right side seems to be about the current opened file. |
@luabud you can have multiple folders opened in the workspace, so is the python version really global across all folders and not per opened file? What if some folders use a different python config? |
In the case of multiple folders, the status bar changes based on the opened editor.
We change the display based on the editor |
@bpasero it's per-folder (technically in can be down to per Is there official guidance in the VS Code extension docs on what should be on the left or right side of the status bar? |
Will keep you posted once we have something for language indicators. |
Hey, I don't think this should be blocked on VS Code. We're able to have the status bar entry positioned for JS/TS using the VS Code's standard public apis: Moving it to the right side would let you avoid duplicating the word There's no timeline on a VS code api for showing language status |
@mjbvz it's not specifically blocked on an official API, just official guidance. The idea of moving it to avoid saying "Python" twice is interesting, but honestly it should say "CPython" to delineate the interpreter and so we won't be saving a word if we do move it (just never bothered since people using other implementations of Python hasn't happened often enough to bother yet). |
I don't think we have official guidance. C# puts their project info on the left, JS/TS goes right (c++ and Java too I believe). My gut feeling though based on what I see extensions doing:
Interpreter can be viewed as fitting in either group, but it'd say it's more of file specific item. @misolori: do we have any guidance on this? Any opinions? |
FYI - If you have a single workspace open, all python files will share the same interpreter. Hence it doesn't change per file. However, if you have a multi-root workspace, it could change per file. |
My main concern with moving this to the left is discoverability. In user studies we've seen that people usually don't pay much attention to the things on the right side of the status bar as they do to the left side. And for Python, the information about which interpreter is selected is very important as you want to make sure the correct environment was picked up (the one that has the specific version of Python for your project, where your packages are installed etc.) |
We discussed about this and we decided we're not moving forward with this idea, as the selected Python environment is related to the workspace itself. |
Similar to what we do with the TypeScript indicator
The text was updated successfully, but these errors were encountered: