Skip to content

Python version indicator should show on the right hand side #5429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bpasero opened this issue Apr 23, 2019 · 11 comments
Closed

Python version indicator should show on the right hand side #5429

bpasero opened this issue Apr 23, 2019 · 11 comments
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality partner ask

Comments

@bpasero
Copy link
Member

bpasero commented Apr 23, 2019

Similar to what we do with the TypeScript indicator

image

@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Apr 23, 2019
@DonJayamanne DonJayamanne added needs decision feature-request Request for new features or functionality labels Apr 23, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Apr 23, 2019
@luabud
Copy link
Member

luabud commented Jun 4, 2019

Is it documented somewhere what extensions should put it on the right or on the left? We'd like to keep it in the left side since it's workspace related info, while on the right side seems to be about the current opened file.

@bpasero
Copy link
Member Author

bpasero commented Jun 5, 2019

@luabud you can have multiple folders opened in the workspace, so is the python version really global across all folders and not per opened file? What if some folders use a different python config?

@DonJayamanne
Copy link

DonJayamanne commented Jun 5, 2019

so is the python version really global across all folders and not per opened file

In the case of multiple folders, the status bar changes based on the opened editor.

What if some folders use a different python config?

We change the display based on the editor

@brettcannon
Copy link
Member

@bpasero it's per-folder (technically in can be down to per .vscode/settings.json). But the git branch changes per-folder for the open file at an even more finer grain as the Python interpreter is tied to .vscode and not potential sub-folders like the git branch.

Is there official guidance in the VS Code extension docs on what should be on the left or right side of the status bar?

@bpasero
Copy link
Member Author

bpasero commented Jun 6, 2019

Is there official guidance in the VS Code extension docs on what should be on the left or right side of the status bar?

Will keep you posted once we have something for language indicators.

@mjbvz
Copy link

mjbvz commented Mar 14, 2020

Hey, I don't think this should be blocked on VS Code. We're able to have the status bar entry positioned for JS/TS using the VS Code's standard public apis:

Screen Shot 2020-03-13 at 6 43 45 PM

Moving it to the right side would let you avoid duplicating the word python twice in the status bar. Here's what the JS/TS extension does:

https://github.com/microsoft/vscode/blob/3f0aeab1ca42cc732eb83107fa1e6c93d81d872d/extensions/typescript-language-features/src/utils/versionStatus.ts#L141

There's no timeline on a VS code api for showing language status

@brettcannon
Copy link
Member

@mjbvz it's not specifically blocked on an official API, just official guidance. The idea of moving it to avoid saying "Python" twice is interesting, but honestly it should say "CPython" to delineate the interpreter and so we won't be saving a word if we do move it (just never bothered since people using other implementations of Python hasn't happened often enough to bother yet).

@mjbvz
Copy link

mjbvz commented Mar 16, 2020

I don't think we have official guidance. C# puts their project info on the left, JS/TS goes right (c++ and Java too I believe).

My gut feeling though based on what I see extensions doing:

  • Things relevant to the current file on the right side
  • Things relevant to the entire workspace on the left side.

Interpreter can be viewed as fitting in either group, but it'd say it's more of file specific item.

@misolori: do we have any guidance on this? Any opinions?

@DonJayamanne
Copy link

DonJayamanne commented Mar 16, 2020

Interpreter can be viewed as fitting in either group, but it'd say it's more of file specific item.

FYI - If you have a single workspace open, all python files will share the same interpreter. Hence it doesn't change per file.

However, if you have a multi-root workspace, it could change per file.

@luabud
Copy link
Member

luabud commented Mar 17, 2020

My main concern with moving this to the left is discoverability. In user studies we've seen that people usually don't pay much attention to the things on the right side of the status bar as they do to the left side. And for Python, the information about which interpreter is selected is very important as you want to make sure the correct environment was picked up (the one that has the specific version of Python for your project, where your packages are installed etc.)

@luabud
Copy link
Member

luabud commented Apr 9, 2020

We discussed about this and we decided we're not moving forward with this idea, as the selected Python environment is related to the workspace itself.

@luabud luabud closed this as completed Apr 9, 2020
@ghost ghost removed the needs decision label Apr 9, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality partner ask
Projects
None yet
Development

No branches or pull requests

7 participants