Skip to content

Use A/B testing on the language server caching support #7478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brettcannon opened this issue Sep 18, 2019 · 8 comments
Closed

Use A/B testing on the language server caching support #7478

brettcannon opened this issue Sep 18, 2019 · 8 comments
Assignees
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. feature-request Request for new features or functionality needs proposal Need to make some design decisions

Comments

@brettcannon
Copy link
Member

Dependent on #7475 .

@brettcannon brettcannon added feature-request Request for new features or functionality area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. needs PR labels Sep 18, 2019
@brettcannon brettcannon added this to the 2019 - September Sprint 2 milestone Sep 18, 2019
@karrtikr
Copy link

karrtikr commented Oct 1, 2019

This experiment will only be active for users using LS, and will have 3 components

  • Caching - System : When setting value is "System"
  • Caching - Library : When setting value is "Library"
  • Caching - control : When setting is not set, i.e "None"

@karrtikr karrtikr self-assigned this Oct 1, 2019
@brettcannon
Copy link
Member Author

Do we want to turn on "System" caching now? I thought that was still being tested/worked out?

@brettcannon
Copy link
Member Author

Or are we going to put in "System" for now but start with a group size of 0?

@karrtikr
Copy link

karrtikr commented Oct 2, 2019

Do we want to turn on "System" caching now? I thought that was still being tested/worked out?

I am just guessing by the title, I don't know what was discussed. We can do group size of 0, or not include "System" at all.

@brettcannon
Copy link
Member Author

@karrtikr probably a group size of 0 to make sure we can control it as soon as a new version of the language server goes out to stable, but we should talk with Tyreke and the MPLS team about if/when they want us to turn that on.

@karrtikr karrtikr removed their assignment Oct 2, 2019
@karrtikr karrtikr added needs proposal Need to make some design decisions and removed needs PR labels Oct 2, 2019
@karrtikr karrtikr removed this from the 2019 - October Sprint 1 milestone Oct 2, 2019
@karrtikr
Copy link

karrtikr commented Oct 2, 2019

If user belongs to say 'Caching - Library' experiment, we have to update settings.json to include python.analysis.cachingLevel setting set to "Library", for the users to be using "Library" caching.

It seems dirty and it has its problems, for eg.

  • When we turn off the experiments, we need to revert the settings back to normal, i.e remove the setting from settings.json. How do we know if it's us who added it in the settings.json, or the user itself?

Ideally we should be A/B testing this setting on the language server side. It will allow us to change the default value of the setting without modifying settings.json.

@kimadeline
Copy link

@luabud is it still relevant, with Pylance and JediLSP available?

@luabud
Copy link
Member

luabud commented Apr 9, 2021

I don't think so, let's close it!

@luabud luabud closed this as completed Apr 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. feature-request Request for new features or functionality needs proposal Need to make some design decisions
Projects
None yet
Development

No branches or pull requests

4 participants