-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Test no pass/fail mark whatever the test name (no upper letter) #7859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Here is a screencast showing the issue: |
Not sure this is related, but after today's update I am having problems running tests. In particular, when I start a test the spinning icon, which normally disappears when the test is completed (to show a green or red icon depending on the result of the test), stays. At the same time, the Log (Window) output shows some errors: [2019-10-10 14:25:29.550] [renderer1] [error] TreeError [CustomView] Data tree node not found: [object Object]: Error: TreeError [CustomView] Data tree node not found: [object Object] Kindly let me know if I should open a new bug report or if this is related. |
@astrozot it doesn't seem the same bug to me. Could you take a look at my screencast above and check if it looks like your problem? If not, I think you should file a new bug. Several regressions in the already buggy unit test feature popped up during last iteration and it's better to increase visibility. IMO this is not a merely nice-to-have feature and it was somewhat shocking to see that such regressions have slipped through QA. |
@memeplex I checked already your screencast and indeed it does look quite differently from what I see. I will fill a new bug as you suggests then. |
Same for me ! but not sure if it is related |
[ @memeplex we edited your ✉️ ⬆️ to come off as more 😃 and less 😠 ] |
Ok, I'm not angry and I apologize if that sounded harsh, but I really believe it's a |
@memeplex thanks for the apology! And we are prioritizing the fix so hopefully we can get it resolved and a point release out. |
Thank you for your good will and hard work, Brett, I just got a bit frustrated because I was expecting a fix for some rough edges and corner cases in the unit testing area and instead it became barely usable. OTOH jupyter integration featured in latest release is impressive, but it worries me that more mundane problems fly under the radar. I'm just reverting until some hot fixes are released, no big deal. |
@gandroz Can you provide details on particular test framework and if possible a minimal repro? I think it might be related to one of the other issues linked to this, that is the Tree view is failing to update. But just to be sure. |
@karthiknadig please have a look at a dummy repo |
Looking at the screencasts and the repo, this issue seems to have the underlying cause as #7898. This has to be addressed in VS Code. Please up vote the issue here microsoft/vscode#82629 if you have not already done so. |
Environment data
Expected behaviour
Using the test tab, after a test is complete (pass of fail) a mark should be displayed.
Actual behaviour
No mark is displayed
The text was updated successfully, but these errors were encountered: