Skip to content

Test no pass/fail mark whatever the test name (no upper letter) #7859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gandroz opened this issue Oct 9, 2019 · 14 comments
Closed

Test no pass/fail mark whatever the test name (no upper letter) #7859

gandroz opened this issue Oct 9, 2019 · 14 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug regression Bug didn't exist in a previous release

Comments

@gandroz
Copy link

gandroz commented Oct 9, 2019

Environment data

  • VS Code version: 1.38.1
  • Extension version (available under the Extensions sidebar): 2019.10.41019
  • OS and version: Ubuntu 18.04
  • Python version (& distribution if applicable, e.g. Anaconda): 3.6.7

Expected behaviour

Using the test tab, after a test is complete (pass of fail) a mark should be displayed.

Actual behaviour

No mark is displayed

@gandroz gandroz added triage-needed Needs assignment to the proper sub-team bug Issue identified by VS Code Team member as probable bug labels Oct 9, 2019
@memeplex
Copy link

memeplex commented Oct 9, 2019

I can confirm this after today's upgrade. It's a regression. There were other problems with unit testing in vscode-python: #7568, #4567. There also is a PR that could fix some of them #7783.

@memeplex
Copy link

memeplex commented Oct 9, 2019

Here is a screencast showing the issue:

Screencast from 09-10-19 19:32:01.zip

@astrozot
Copy link

Not sure this is related, but after today's update I am having problems running tests. In particular, when I start a test the spinning icon, which normally disappears when the test is completed (to show a green or red icon depending on the result of the test), stays. At the same time, the Log (Window) output shows some errors:

[2019-10-10 14:25:29.550] [renderer1] [error] TreeError [CustomView] Data tree node not found: [object Object]: Error: TreeError [CustomView] Data tree node not found: [object Object]
at Y.getDataNode (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1045:675)
at Y.rerender (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1043:295)
at t.visible.e.map.e (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:4974:446)
at Array.map ()
at U.doRefresh (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:4974:437)
at process._tickCallback (internal/process/next_tick.js:68:7)

Kindly let me know if I should open a new bug report or if this is related.

@memeplex
Copy link

@astrozot it doesn't seem the same bug to me. Could you take a look at my screencast above and check if it looks like your problem? If not, I think you should file a new bug. Several regressions in the already buggy unit test feature popped up during last iteration and it's better to increase visibility. IMO this is not a merely nice-to-have feature and it was somewhat shocking to see that such regressions have slipped through QA.

@astrozot
Copy link

@memeplex I checked already your screencast and indeed it does look quite differently from what I see. I will fill a new bug as you suggests then.

@gandroz
Copy link
Author

gandroz commented Oct 10, 2019

Not sure this is related, but after today's update I am having problems running tests. In particular, when I start a test the spinning icon, which normally disappears when the test is completed (to show a green or red icon depending on the result of the test), stays. At the same time, the Log (Window) output shows some errors:

[2019-10-10 14:25:29.550] [renderer1] [error] TreeError [CustomView] Data tree node not found: [object Object]: Error: TreeError [CustomView] Data tree node not found: [object Object]
at Y.getDataNode (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1045:675)
at Y.rerender (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1043:295)
at t.visible.e.map.e (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:4974:446)
at Array.map ()
at U.doRefresh (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:4974:437)
at process._tickCallback (internal/process/next_tick.js:68:7)

Kindly let me know if I should open a new bug report or if this is related.

Same for me ! but not sure if it is related
Screencast.zip

@astrozot
Copy link

@gandroz I opened a new issue, #7898, you can check if this is also the problem you encounter.

@brettcannon
Copy link
Member

[ @memeplex we edited your ✉️ ⬆️ to come off as more 😃 and less 😠 ]

@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Oct 10, 2019
@memeplex
Copy link

Ok, I'm not angry and I apologize if that sounded harsh, but I really believe it's a severe regression.

@brettcannon
Copy link
Member

@memeplex thanks for the apology! And we are prioritizing the fix so hopefully we can get it resolved and a point release out.

@memeplex
Copy link

Thank you for your good will and hard work, Brett, I just got a bit frustrated because I was expecting a fix for some rough edges and corner cases in the unit testing area and instead it became barely usable. OTOH jupyter integration featured in latest release is impressive, but it worries me that more mundane problems fly under the radar. I'm just reverting until some hot fixes are released, no big deal.

@karthiknadig
Copy link
Member

@gandroz Can you provide details on particular test framework and if possible a minimal repro? I think it might be related to one of the other issues linked to this, that is the Tree view is failing to update. But just to be sure.

@karthiknadig karthiknadig added info-needed Issue requires more information from poster and removed triage labels Oct 17, 2019
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Oct 17, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Oct 17, 2019
@gandroz
Copy link
Author

gandroz commented Oct 17, 2019

@karthiknadig please have a look at a dummy repo
It does not have exactly the same behaviour as I describe here, but it has a related bug for sure. Whereas in my current project the icons stay in the unknown status, in this dummy sample repo the status icons eventually loop indefinitely (see the readme)

@brettcannon brettcannon added regression Bug didn't exist in a previous release and removed info-needed Issue requires more information from poster labels Oct 23, 2019
@ericsnowcurrently ericsnowcurrently removed their assignment Oct 28, 2019
@karthiknadig
Copy link
Member

Looking at the screencasts and the repo, this issue seems to have the underlying cause as #7898. This has to be addressed in VS Code.

Please up vote the issue here microsoft/vscode#82629 if you have not already done so.

@ghost ghost removed the triage label Nov 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug regression Bug didn't exist in a previous release
Projects
None yet
Development

No branches or pull requests

7 participants