Skip to content

Add caching to PythonExecutionService.getExecutablePath(). #8509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ericsnowcurrently opened this issue Nov 11, 2019 · 1 comment
Closed
Labels
area-terminal debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs spike Label for issues that need investigation before they can be worked on.

Comments

@ericsnowcurrently
Copy link

Every time PythonExecutionService.getExecutablePath() is called, it does a file stat and potentially an exec(). This is inefficient. It would make sense to instead cache the value returned from this function. ("this.executable"?) The value might need to be cached in the factory (if we aren't caching PythonExecutionService objects there already).

I suppose there is a risk that the file gets deleted later, causing hard-to-debug failures, but that is unlikely and already mostly an existing possible problem (which we never get complaints about...).

@ericsnowcurrently ericsnowcurrently added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. area-terminal needs proposal Need to make some design decisions labels Nov 11, 2019
@karthiknadig karthiknadig removed the needs proposal Need to make some design decisions label Aug 18, 2020
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Aug 18, 2020
@karthiknadig karthiknadig added the needs spike Label for issues that need investigation before they can be worked on. label Aug 18, 2020
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Aug 18, 2020
@karrtikr
Copy link

Did this at some point.

@karrtikr karrtikr closed this as not planned Won't fix, can't repro, duplicate, stale Dec 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-terminal debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs spike Label for issues that need investigation before they can be worked on.
Projects
None yet
Development

No branches or pull requests

3 participants