Skip to content

Spike - More than 1/2 of our users use Python environments that are of type unknown #9417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DonJayamanne opened this issue Jan 7, 2020 · 2 comments
Labels
area-environments Features relating to handling interpreter environments bug Issue identified by VS Code Team member as probable bug needs spike Label for issues that need investigation before they can be worked on. verified Verification succeeded
Milestone

Comments

@DonJayamanne
Copy link

To improve the overall extension we need to understand what this unknown is.

  • Its possible environments are not getting activated when they can?
    • This could impact debugging, linting, running code in terminal, etc.
  • Its possible these are users using plain python installations that cannot be activated, in which case setting path variable in shell will ensure the right environment will get picked when user types python (we have an issue for this)
  • Avoids confusions arising from interpreter type being labeled as Unknown in captured telemetry.

Note:

  • Global python installations could fall into this category (/usr/bin/python)
  • Python installations in C:/Program Files/Python/python.exe or similar) could fall into this category

Suggestions:

  • When an interpreter is identified as unknown we should:
    • Check if the path is /usr/bin/python or <Program Files>/Python/python.exe or <User dir>/App Data/.... or similar (is this a standard install of python?)
    • Does the name virtualenv or similar exist in the path? (indicates we haven't been able to identify a conda environment, hence indicative of a bug/room for improvement.)
    • Does the name conda exist in the path? (indicates we haven't been able to identify a conda environment, hence indicative of a bug/room for improvement)
    • Does the name miniconda exist in the path? (indicates we haven't been able to identify a conda environment, hence indicative of a bug/room for improvement)
  • Where is this environment?
    • In program files directory
    • In workspace directory
    • In users home directory
    • Other special paths..
  • Whats the break down of these unknowns:
    • Version of Python
    • Type of OS

What next :

  • Later depending on which categories these unknown environments fall into we could take additional actions:
    • E.g. if it exists in a conda dir but identified as unknown, we can prompt user to send additional information for diagnostic purposes?
    • E.g. if it exists in a virtual env dir but identified as unknown, we can prompt user to send additional information for diagnostic purposes?
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug triage-needed Needs assignment to the proper sub-team labels Jan 7, 2020
@karthiknadig karthiknadig changed the title More than 1/2 of our users use Python environments that are of type unknown Spike - More than 1/2 of our users use Python environments that are of type unknown Jan 7, 2020
@karthiknadig karthiknadig added the needs proposal Need to make some design decisions label Jan 7, 2020
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Jan 7, 2020
@karthiknadig karthiknadig added triage-needed Needs assignment to the proper sub-team area-environments Features relating to handling interpreter environments and removed triage-needed Needs assignment to the proper sub-team labels Jan 7, 2020
@luabud luabud added needs spike Label for issues that need investigation before they can be worked on. and removed needs proposal Need to make some design decisions labels Mar 12, 2020
@luabud
Copy link
Member

luabud commented Feb 16, 2021

We should verify this as we roll out #12020

@karrtikr
Copy link

No longer an issue 🎉

@karrtikr karrtikr added this to the October 2021 milestone Oct 22, 2021
@karrtikr karrtikr added the verified Verification succeeded label Oct 25, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-environments Features relating to handling interpreter environments bug Issue identified by VS Code Team member as probable bug needs spike Label for issues that need investigation before they can be worked on. verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants