Skip to content

Salsa Doesn't Provide Intellisense When Using Import Statements #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joshuaskelton opened this issue Feb 18, 2016 · 6 comments
Closed
Labels
known-issues Known issues for extension, most of them are external issues
Milestone

Comments

@joshuaskelton
Copy link
Contributor

Salsa IntelliSense does not work when using ES6 style import statments. I've tried tweaking some tsconfig.json settings, but without much luck.

This does not work:
import React, { AppRegistry } from 'react-native';

But this does:
var React = require('react-native'); var { AppRegistry } = React;

This is a known TypeScript issue:
microsoft/TypeScript#7000

@dlebu dlebu added this to the v1 milestone Feb 19, 2016
@nisheetjain nisheetjain added the known-issues Known issues for extension, most of them are external issues label Feb 20, 2016
@billti
Copy link
Member

billti commented Feb 29, 2016

Fix is out for review. See microsoft/TypeScript#7249 (comment)

@joshuaskelton
Copy link
Contributor Author

Thanks for keeping us looped in! 👍

@ghost ghost added the external label Feb 29, 2016
@joshuaskelton
Copy link
Contributor Author

Looks like the change was merged. I'll verify once we get the typescript bits.

@zchrykng
Copy link

Any update on when this fix will be pushed out? Negates one of the most awesome features of VSCode, at least for my current project.

@egamma
Copy link
Member

egamma commented Mar 22, 2016

@zchrykng The fix is available in the latest VS Code insiders build. Pls see https://code.visualstudio.com/blogs/2016/02/01/introducing_insiders_build

You need to enable "allowSyntheticDefaultImports". This is the jsconfig.json:

jsconfig.json

 {
    "compilerOptions": {
        "allowSyntheticDefaultImports": true
    }
}

image

@zchrykng
Copy link

@egamma Awesome. Thanks! Installing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
known-issues Known issues for extension, most of them are external issues
Projects
None yet
Development

No branches or pull requests

7 participants