fix microsoft/vscode#108726

Author: jrieken

src/references/index.ts

@@ -27,6 +27,31 @@ export function register(tree: SymbolsTree, context: vscode.ExtensionContext): v
 		vscode.commands.registerCommand('references-view.copyAll', copyAllCommand),
 		vscode.commands.registerCommand('references-view.copyPath', copyPathCommand),
 	);
+
+
+	// --- references.preferredLocation setting
+
+	let showReferencesDisposable: vscode.Disposable | undefined;
+	const config = 'references.preferredLocation';
+	function updateShowReferences(event?: vscode.ConfigurationChangeEvent) {
+		if (event && !event.affectsConfiguration(config)) {
+			return;
+		}
+		const value = vscode.workspace.getConfiguration().get<string>(config);
+
+		showReferencesDisposable?.dispose();
+		showReferencesDisposable = undefined;
+
+		if (value === 'view') {
+			showReferencesDisposable = vscode.commands.registerCommand('editor.action.showReferences', async (uri: vscode.Uri, position: vscode.Position, locations: vscode.Location[]) => {
+				const input = new ReferencesTreeInput('References', new vscode.Location(uri, position), 'vscode.executeReferenceProvider', locations);
+				tree.setInput(input);
+			});
+		}
+	};
+	context.subscriptions.push(vscode.workspace.onDidChangeConfiguration(updateShowReferences));
+	context.subscriptions.push({ dispose: () => showReferencesDisposable?.dispose() });
+	updateShowReferences();
 }
 
 const copyAllCommand = async (item: ReferenceItem | FileItem | unknown) => {

src/references/model.ts

@@ -15,20 +15,27 @@ export class ReferencesTreeInput implements SymbolTreeInput<FileItem | Reference
 		readonly title: string,
 		readonly location: vscode.Location,
 		private readonly _command: string,
+		private readonly _result?: vscode.Location[] | vscode.LocationLink[]
 	) {
 		this.contextValue = _command;
 	}
 
 	async resolve() {
 
-		const result = Promise.resolve(vscode.commands.executeCommand<vscode.Location[] | vscode.LocationLink[]>(this._command, this.location.uri, this.location.range.start));
-		const model = new ReferencesModel(await result ?? []);
-		const provider = new ReferencesTreeDataProvider(model);
+		let model: ReferencesModel;
+		if (this._result) {
+			model = new ReferencesModel(this._result);
+		} else {
+			const resut = await Promise.resolve(vscode.commands.executeCommand<vscode.Location[] | vscode.LocationLink[]>(this._command, this.location.uri, this.location.range.start));
+			model = new ReferencesModel(resut ?? []);
+		}
 
 		if (model.items.length === 0) {
 			return;
 		}
 
+		const provider = new ReferencesTreeDataProvider(model);
+
 		return {
 			provider,
 			get message() { return model.message; },