Skip to content

Commit 0febc54

Browse files
Revert "fixes #170559 (#170567)"
This reverts commit fb26225.
1 parent 53830a5 commit 0febc54

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

src/vs/base/parts/quickinput/browser/quickInputList.ts

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,11 @@ class ListElementRenderer implements IListRenderer<ListElement, IListElementTemp
119119

120120
// Checkbox
121121
const label = dom.append(data.entry, $('label.quick-input-list-label'));
122+
data.toDisposeTemplate.push(dom.addStandardDisposableListener(label, dom.EventType.CLICK, e => {
123+
if (!data.checkbox.offsetParent) { // If checkbox not visible:
124+
e.preventDefault(); // Prevent toggle of checkbox when it is immediately shown afterwards. #91740
125+
}
126+
}));
122127
data.checkbox = <HTMLInputElement>dom.append(label, $('input.quick-input-list-checkbox'));
123128
data.checkbox.type = 'checkbox';
124129
data.toDisposeTemplate.push(dom.addStandardDisposableListener(data.checkbox, dom.EventType.CHANGE, e => {
@@ -350,6 +355,12 @@ export class QuickInputList {
350355

351356
this._onKeyDown.fire(event);
352357
}));
358+
this.disposables.push(this.list.onMouseDown(e => {
359+
if (e.browserEvent.button !== 2) {
360+
// Works around / fixes #64350.
361+
e.browserEvent.preventDefault();
362+
}
363+
}));
353364
this.disposables.push(dom.addDisposableListener(this.container, dom.EventType.CLICK, e => {
354365
if (e.x || e.y) { // Avoid 'click' triggered by 'space' on checkbox.
355366
this._onLeave.fire();

0 commit comments

Comments
 (0)