rename failed -> installLocally

Author: joshspicer

src/vs/platform/environment/node/argv.ts

@@ -101,7 +101,7 @@ export const OPTIONS: OptionDescriptions<Required<NativeParsedArgs>> = {
 	'install-extension': { type: 'string[]', cat: 'e', args: 'ext-id | path', description: localize('installExtension', "Installs or updates an extension. The argument is either an extension id or a path to a VSIX. The identifier of an extension is '${publisher}.${name}'. Use '--force' argument to update to latest version. To install a specific version provide '@${version}'. For example: '[email protected]'.") },
 	'pre-release': { type: 'boolean', cat: 'e', description: localize('install prerelease', "Installs the pre-release version of the extension, when using --install-extension") },
 	'uninstall-extension': { type: 'string[]', cat: 'e', args: 'ext-id', description: localize('uninstallExtension', "Uninstalls an extension.") },
-	'download-extensions-locally': { type: 'boolean', cat: 'e', description: localize('downloadExtensionsLocally', "When enabled extensions are downloaded locally and installed on remote") },
+	'download-extensions-locally': { type: 'boolean', cat: 'e', description: localize('downloadExtensionsLocally', "When enabled extensions are downloaded locally and then installed on remote") },
 	'update-extensions': { type: 'boolean', cat: 'e', description: localize('updateExtensions', "Update the installed extensions.") },
 	'enable-proposed-api': { type: 'string[]', allowEmptyValue: true, cat: 'e', args: 'ext-id', description: localize('experimentalApis', "Enables proposed API features for extensions. Can receive one or more extension IDs to enable individually.") },
 

src/vs/platform/extensionManagement/common/extensionManagement.ts

@@ -540,7 +540,7 @@ export class ExtensionManagementError extends Error {
 }
 
 export interface InstallExtensionSummary {
-	failed: {
+	installLocally: {
 		id: string;
 		installOptions: InstallOptions;
 	}[];

src/vs/server/node/remoteExtensionsScanner.ts

@@ -29,8 +29,8 @@ export class RemoteExtensionsScannerService implements IRemoteExtensionsScannerS
 
 	readonly _serviceBrand: undefined;
 
-	private readonly _whenBuiltinExtensionsReady = Promise.resolve<InstallExtensionSummary>({ failed: [] });
-	private readonly _whenExtensionsReady = Promise.resolve<InstallExtensionSummary>({ failed: [] });
+	private readonly _whenBuiltinExtensionsReady = Promise.resolve<InstallExtensionSummary>({ installLocally: [] });
+	private readonly _whenExtensionsReady = Promise.resolve<InstallExtensionSummary>({ installLocally: [] });
 
 	constructor(
 		private readonly _extensionManagementCLI: ExtensionManagementCLI,
@@ -51,10 +51,10 @@ export class RemoteExtensionsScannerService implements IRemoteExtensionsScannerS
 				.then(() => {
 					performance.mark('code/server/didInstallBuiltinExtensions');
 					_logService.trace('Finished installing builtin extensions');
-					return { failed: [] };
+					return { installLocally: [] };
 				}, error => {
 					_logService.error(error);
-					return { failed: [] };
+					return { installLocally: [] };
 				});
 		}
 
@@ -70,7 +70,7 @@ export class RemoteExtensionsScannerService implements IRemoteExtensionsScannerS
 				_logService.trace('Installing extensions later...');
 				this._whenExtensionsReady = this._whenBuiltinExtensionsReady
 					.then(async () => {
-						return { failed: extensionsToInstall.map(id => ({ id, installOptions })) };
+						return { installLocally: extensionsToInstall.map(id => ({ id, installOptions })) };
 					});
 				return;
 			}
@@ -80,11 +80,11 @@ export class RemoteExtensionsScannerService implements IRemoteExtensionsScannerS
 				.then(() => _extensionManagementCLI.installExtensions(this._asExtensionIdOrVSIX(extensionsToInstall), [], installOptions, !!environmentService.args['force']))
 				.then(async () => {
 					_logService.trace('Finished installing extensions');
-					return { failed: [] };
+					return { installLocally: [] };
 				}, async error => {
 					_logService.error(error);
 
-					const failed: {
+					const installLocally: {
 						id: string;
 						installOptions: InstallOptions;
 					}[] = [];
@@ -93,18 +93,18 @@ export class RemoteExtensionsScannerService implements IRemoteExtensionsScannerS
 					for (const id of this._asExtensionIdOrVSIX(extensionsToInstall)) {
 						if (typeof id === 'string') {
 							if (!alreadyInstalled.some(e => areSameExtensions(e.identifier, { id }))) {
-								failed.push({ id, installOptions });
+								installLocally.push({ id, installOptions });
 							}
 						}
 					}
 
-					if (!failed.length) {
+					if (!installLocally.length) {
 						_logService.trace(`No extensions to report as failed`);
-						return { failed: [] };
+						return { installLocally: [] };
 					}
 
-					_logService.info(`Relaying the following extensions to install later: ${failed.map(f => f.id).join(', ')}`);
-					return { failed };
+					_logService.info(`Relaying the following extensions to install later: ${installLocally.map(f => f.id).join(', ')}`);
+					return { installLocally };
 				});
 		}
 	}

src/vs/workbench/contrib/extensions/electron-sandbox/remoteExtensionsInit.ts

@@ -84,8 +84,8 @@ export class InstallRemoteExtensionsContribution implements IWorkbenchContributi
 			return;
 		}
 
-		const { failed } = await this.remoteExtensionsScannerService.whenExtensionsReady();
-		if (failed.length === 0) {
+		const { installLocally } = await this.remoteExtensionsScannerService.whenExtensionsReady();
+		if (installLocally.length === 0) {
 			this.logService.trace('No extensions relayed from server');
 			return;
 		}
@@ -95,10 +95,10 @@ export class InstallRemoteExtensionsContribution implements IWorkbenchContributi
 			return;
 		}
 
-		this.logService.info(`Installing '${failed.length}' extensions relayed from server`);
-		const galleryExtensions = await this.extensionGalleryService.getExtensions(failed.map(({ id }) => ({ id })), CancellationToken.None);
+		this.logService.info(`Installing '${installLocally.length}' extensions relayed from server`);
+		const galleryExtensions = await this.extensionGalleryService.getExtensions(installLocally.map(({ id }) => ({ id })), CancellationToken.None);
 		const installExtensionInfo: InstallExtensionInfo[] = [];
-		for (const { id, installOptions } of failed) {
+		for (const { id, installOptions } of installLocally) {
 			const extension = galleryExtensions.find(e => areSameExtensions(e.identifier, { id }));
 			if (extension) {
 				installExtensionInfo.push({

src/vs/workbench/contrib/remote/electron-sandbox/remote.contribution.ts

@@ -200,7 +200,7 @@ Registry.as<IConfigurationRegistry>(ConfigurationExtensions.Configuration)
 		properties: {
 			'remote.downloadExtensionsLocally': {
 				type: 'boolean',
-				markdownDescription: nls.localize('remote.downloadExtensionsLocally', "When enabled extensions are downloaded locally and installed on remote."),
+				markdownDescription: nls.localize('remote.downloadExtensionsLocally', "When enabled extensions are downloaded locally and then installed on remote."),
 				default: false
 			},
 		}

src/vs/workbench/services/remote/common/remoteExtensionsScanner.ts

@@ -36,7 +36,7 @@ class RemoteExtensionsScannerService implements IRemoteExtensionsScannerService
 	whenExtensionsReady(): Promise<InstallExtensionSummary> {
 		return this.withChannel(
 			channel => channel.call<InstallExtensionSummary>('whenExtensionsReady'),
-			{ failed: [] }
+			{ installLocally: [] }
 		);
 	}
 

src/vs/workbench/test/browser/workbenchTestServices.ts

@@ -2171,7 +2171,7 @@ export class TestRemoteAgentService implements IRemoteAgentService {
 
 export class TestRemoteExtensionsScannerService implements IRemoteExtensionsScannerService {
 	declare readonly _serviceBrand: undefined;
-	async whenExtensionsReady(): Promise<InstallExtensionSummary> { return { failed: [] }; }
+	async whenExtensionsReady(): Promise<InstallExtensionSummary> { return { installLocally: [] }; }
 	scanExtensions(): Promise<IExtensionDescription[]> { throw new Error('Method not implemented.'); }
 }