Skip to content

Commit 9ebb7c4

Browse files
committed
Promote Terminal.creationOptions to stable
The API did not have a proposed API guard in place Fixes #63052
1 parent b95f32b commit 9ebb7c4

File tree

2 files changed

+7
-13
lines changed

2 files changed

+7
-13
lines changed

src/vs/vscode.d.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4854,6 +4854,13 @@ declare module 'vscode' {
48544854
*/
48554855
readonly processId: Thenable<number | undefined>;
48564856

4857+
/**
4858+
* The object used to initialize the terminal, this is useful for example to detecting the
4859+
* shell type of when the terminal was not launched by this extension or for detecting what
4860+
* folder the shell was launched in.
4861+
*/
4862+
readonly creationOptions: Readonly<TerminalOptions | ExtensionTerminalOptions>;
4863+
48574864
/**
48584865
* Send text to the terminal. The text is written to the stdin of the underlying pty process
48594866
* (shell) of the terminal.

src/vs/vscode.proposed.d.ts

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -987,19 +987,6 @@ declare module 'vscode' {
987987

988988
//#endregion
989989

990-
//#region Terminal creation options https://github.com/microsoft/vscode/issues/63052
991-
992-
export interface Terminal {
993-
/**
994-
* The object used to initialize the terminal, this is useful for things like detecting the
995-
* shell type of shells not launched by the extension or detecting what folder the shell was
996-
* launched in.
997-
*/
998-
readonly creationOptions: Readonly<TerminalOptions | ExtensionTerminalOptions>;
999-
}
1000-
1001-
//#endregion
1002-
1003990
//#region Terminal dimensions property and change event https://github.com/microsoft/vscode/issues/55718
1004991

1005992
/**

0 commit comments

Comments
 (0)