Skip to content

Commit c112f84

Browse files
committed
less innerHTML usage, eg. textContent for styles and innerText for labels
1 parent 5920e71 commit c112f84

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

src/vs/editor/contrib/codelens/codelensController.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ export class CodeLensContribution implements IEditorContribution {
9595
.monaco-editor .codelens-decoration.${this._styleClassName} { height: ${height}px; line-height: ${lineHeight}px; font-size: ${fontSize}px; padding-right: ${Math.round(fontInfo.fontSize * 0.45)}px;}
9696
.monaco-editor .codelens-decoration.${this._styleClassName} > a > .codicon { line-height: ${lineHeight}px; font-size: ${fontSize}px; }
9797
`;
98-
this._styleElement.innerHTML = newStyle;
98+
this._styleElement.textContent = newStyle;
9999
}
100100

101101
private _localDispose(): void {
@@ -470,5 +470,3 @@ registerEditorAction(class ShowLensesInCurrentLine extends EditorAction {
470470
}
471471
}
472472
});
473-
474-

src/vs/editor/contrib/gotoError/gotoErrorWidget.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ class MessageWidget {
167167

168168
let relatedResource = document.createElement('a');
169169
dom.addClass(relatedResource, 'filename');
170-
relatedResource.innerHTML = `${getBaseLabel(related.resource)}(${related.startLineNumber}, ${related.startColumn}): `;
170+
relatedResource.innerText = `${getBaseLabel(related.resource)}(${related.startLineNumber}, ${related.startColumn}): `;
171171
relatedResource.title = getPathLabel(related.resource, undefined);
172172
this._relatedDiagnostics.set(relatedResource, related);
173173

src/vs/editor/contrib/gotoSymbol/peek/referencesWidget.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -429,7 +429,7 @@ export class ReferenceWidget extends peekView.PeekViewWidget {
429429

430430
if (this._model.isEmpty) {
431431
this.setTitle('');
432-
this._messageContainer.innerHTML = nls.localize('noResults', "No results");
432+
this._messageContainer.innerText = nls.localize('noResults', "No results");
433433
dom.show(this._messageContainer);
434434
return Promise.resolve(undefined);
435435
}

0 commit comments

Comments
 (0)