final init order fixes #243049

Author: jrieken

build/lib/propertyInitOrderChecker.js

@@ -22,13 +22,6 @@ const TS_CONFIG_PATH = path.join(__dirname, '../../', 'src', 'tsconfig.json');
 // #############################################################################################
 //
 
-const ignored = new Set([
-	'vs/editor/browser/view/viewLayer.ts',
-	'vs/platform/accessibilitySignal/browser/accessibilitySignalService.ts',
-	'vs/editor/contrib/inlayHints/browser/inlayHintsController.ts',
-	'vs/workbench/contrib/editSessions/browser/editSessionsStorageService.ts',
-	'vs/workbench/api/common/extHostLanguageFeatures.ts',
-]);
 
 const cancellationToken: ts.CancellationToken = {
 	isCancellationRequested: () => false,
@@ -59,12 +52,6 @@ for (const file of program.getSourceFiles()) {
 	if (!file || file.isDeclarationFile) {
 		continue;
 	}
-
-	const relativePath = path.relative(path.dirname(TS_CONFIG_PATH), file.fileName).replace(/\\/g, '/');
-	if (ignored.has(relativePath)) {
-		continue;
-	}
-
 	visit(file);
 }
 

build/lib/propertyInitOrderChecker.ts

@@ -1335,14 +1335,15 @@ class InlineCompletionAdapter {
 		items: readonly vscode.InlineCompletionItem[];
 	}>();
 
-	private readonly _isAdditionsProposedApiEnabled = isProposedApiEnabled(this._extension, 'inlineCompletionsAdditions');
+	private readonly _isAdditionsProposedApiEnabled: boolean;
 
 	constructor(
 		private readonly _extension: IExtensionDescription,
 		private readonly _documents: ExtHostDocuments,
 		private readonly _provider: vscode.InlineCompletionItemProvider,
 		private readonly _commands: CommandsConverter,
 	) {
+		this._isAdditionsProposedApiEnabled = isProposedApiEnabled(this._extension, 'inlineCompletionsAdditions');
 	}
 
 	public get supportsHandleEvents(): boolean {

src/vs/workbench/api/common/extHostLanguageFeatures.ts

@@ -35,7 +35,7 @@ export class EditSessionsWorkbenchService extends Disposable implements IEditSes
 
 	public readonly SIZE_LIMIT = Math.floor(1024 * 1024 * 1.9); // 2 MB
 
-	private serverConfiguration = this.productService['editSessions.store'];
+	private serverConfiguration;
 	private machineClient: IUserDataSyncMachinesService | undefined;
 
 	private authenticationInfo: { sessionId: string; token: string; providerId: string } | undefined;
@@ -84,7 +84,7 @@ export class EditSessionsWorkbenchService extends Disposable implements IEditSes
 		@ISecretStorageService private readonly secretStorageService: ISecretStorageService
 	) {
 		super();
-
+		this.serverConfiguration = this.productService['editSessions.store'];
 		// If the user signs out of the current session, reset our cached auth state in memory and on disk
 		this._register(this.authenticationService.onDidChangeSessions((e) => this.onDidChangeSessions(e.event)));