Skip to content

Commit ff43f8b

Browse files
authored
workbench.action.tasks.build no longer triggers build but opens a list of tasks (#130043)
Fixes #130028
1 parent 4101265 commit ff43f8b

1 file changed

Lines changed: 7 additions & 2 deletions

File tree

src/vs/workbench/contrib/tasks/common/taskConfiguration.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1741,9 +1741,14 @@ namespace TaskParser {
17411741
}
17421742
context.taskLoadIssues = Objects.deepClone(baseLoadIssues);
17431743
}
1744-
if ((defaultBuildTask.rank > -1) && (defaultBuildTask.rank < 2) && defaultBuildTask.task) {
1744+
// There is some special logic for tasks with the labels "build" and "test".
1745+
// Even if they are not marked as a task group Build or Test, we automagically group them as such.
1746+
// However, if they are already grouped as Build or Test, we don't need to add this grouping.
1747+
const defaultBuildGroupName = Types.isString(defaultBuildTask.task?.configurationProperties.group) ? defaultBuildTask.task?.configurationProperties.group : defaultBuildTask.task?.configurationProperties.group?._id;
1748+
const defaultTestTaskGroupName = Types.isString(defaultTestTask.task?.configurationProperties.group) ? defaultTestTask.task?.configurationProperties.group : defaultTestTask.task?.configurationProperties.group?._id;
1749+
if ((defaultBuildGroupName !== Tasks.TaskGroup.Build._id) && (defaultBuildTask.rank > -1) && (defaultBuildTask.rank < 2) && defaultBuildTask.task) {
17451750
defaultBuildTask.task.configurationProperties.group = Tasks.TaskGroup.Build;
1746-
} else if ((defaultTestTask.rank > -1) && (defaultTestTask.rank < 2) && defaultTestTask.task) {
1751+
} else if ((defaultTestTaskGroupName !== Tasks.TaskGroup.Test._id) && (defaultTestTask.rank > -1) && (defaultTestTask.rank < 2) && defaultTestTask.task) {
17471752
defaultTestTask.task.configurationProperties.group = Tasks.TaskGroup.Test;
17481753
}
17491754

0 commit comments

Comments
 (0)