Snippets + Auto-closing pairs don't compliment each other

[TylerLeonhardt]

Version: 1.49.0-insider
Commit: 11dc5a8
Date: 2020-08-17T17:11:16.078Z (1 day ago)
Electron: 9.2.0
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Darwin x64 19.6.0

Steps to Reproduce:

Add the following python snippet:

"listcompPy": {
		"prefix":"[x for x in",
		"body":[
			"[x for x in range(1,20) if x%2==0 ]"
		]
	}

or PowerShell snippet:

"PSCustomObject": {
        "prefix":"[PSCustomObject",
        "body":[
            "[PSCustomObject] @{ Key = Value }"
        ]
    }

1. type: [ which will cause auto-closing pair... (at this point you have [|] where | is the cursor)
2. then add a x or psc and hit TAB or ENTER on the intellisense item

Expected

Python

[x for x in range(1,20) if x%2==0 ]

PowerShell

[PSCustomObject]@{
    Name = Value
}

Actual

Python

[x for x in range(1,20) if x%2==0 ]]

PowerShell

[PSCustomObject]@{
    Name = Value
}]

NOTE THE TRAILING ]. Snippets and auto-closing pairs should play nice together so that the whole experience generates valid code.

Does this issue occur when all extensions are disabled?: Yes

[TylerLeonhardt]

Here's a javascript example for array destructuring:

"arraydestructuring": {
        "prefix": "[a",
        "body": [
            "[a, b, ...next] = ${1:array}"
        ],
        "description": "arraydestructuring"
    }

which gets you:

[a, b, ...next] = array]

when you type: [a<TAB or ENTER to accept intellisense>

[TylerLeonhardt]

better example!

A javascript example for Symbol.iterator:

"SymbolIterator": {
		"prefix": "[Symbol.iterator",
		"body": [
			"[Symbol.iterator]: () => {",
			"    return {",
			"        next: () => {",
			"            return { value: value, done: false };",
			"        }",
			"    };",
			"}"
		]
	}

which gets you:

[Symbol.iterator]: () => {
        return {
            next: () => {
                return { value: value, done: false };
            }
        };
    }]

Notice the extra ] at the end

when you type: [Symbol<TAB or ENTER to accept intellisense>

[TylerLeonhardt]

for verification, this:

"PSCustomObject": {
        "prefix":"[PSCustomObject]",
        "body":[
            "[PSCustomObject] @{ Key = Value }"
        ]
    }

should get you:

[PSCusomObject] @{ Key = Value }

on insert mode replace (default is SHIFT + ENTER)

[ArturoDent]

I'll note that it works fine in non-json files, but is reversed in a json file (as are the insert/replace hints in the suggestion box).

W10

[TylerLeonhardt]

that seems like a separate issue not related to this fix. Can you open a new issue?

[ArturoDent]

Yes, I'll open another issue.