VS Code renderer crashes when setting certain breakpoints

[rebornix]

no 100% reproduce but very often that when I debug a unit test in vscode repo through the self host test extension, the process crashes.

#
# Fatal error in , line 0
# ignored
#
#
#
#FailureMessage Object: 0x7ffee59af6300   Electron Framework                  0x0000000112872879 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 6161385
1   Electron Framework                  0x0000000115965473 v8::internal::compiler::ZoneStats::GetCurrentAllocatedBytes() const + 12547347
2   Electron Framework                  0x00000001171f1f0d v8::internal::compiler::ZoneStats::GetCurrentAllocatedBytes() const + 38289325
3   Electron Framework                  0x00000001171dfad1 v8::internal::compiler::ZoneStats::GetCurrentAllocatedBytes() const + 38214513
4   Electron Framework                  0x0000000111f59012 v8::internal::RegExpParser::ParseRegExp(v8::internal::Isolate*, v8::internal::Zone*, v8::internal::FlatStringReader*, v8::base::Flags<v8::internal::JSRegExp::Flag, int>, v8::internal::RegExpCompileData*) + 1762
5   Electron Framework                  0x0000000111f53508 v8::internal::RegExpMacroAssembler::LoadCurrentCharacter(int, v8::internal::Label*, bool, int, int) + 1336
6   Electron Framework                  0x0000000111f5bb71 v8::internal::RegExp::Exec(v8::internal::Isolate*, v8::internal::Handle<v8::internal::JSRegExp>, v8::internal::Handle<v8::internal::String>, int, v8::internal::Handle<v8::internal::RegExpMatchInfo>) + 4465
7   Electron Framework                  0x0000000111f5aaf8 v8::internal::RegExp::Exec(v8::internal::Isolate*, v8::internal::Handle<v8::internal::JSRegExp>, v8::internal::Handle<v8::internal::String>, int, v8::internal::Handle<v8::internal::RegExpMatchInfo>) + 248
8   Electron Framework                  0x0000000111f6e0c1 v8::internal::Runtime::SetObjectProperty(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, v8::internal::StoreOrigin, v8::Maybe<v8::internal::ShouldThrow>) + 19761
9   Electron Framework                  0x00000001123006f8 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 451176
10  Electron Framework                  0x0000000112351c7b v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 784363
Renderer process crashed with: {"reason":"crashed","exitCode":4}
Waiting for the debugger to disconnect...

[rebornix]

Added paper cut label as it's kind of frustrating to debug unit test in our repo as it fails more than 90% of the time sometimes.

[rebornix]

Sometimes the breakpoint just doesn't hit even if the debugger is attached.

Debugger listening on ws://127.0.0.1:56462/93767fef-f6bf-4c7f-958f-051cd7475bed
For help, see: https://nodejs.org/en/docs/inspector
Debugger attached.

DevTools listening on ws://127.0.0.1:9222/devtools/browser/1b2f568c-968a-4c46-91a4-e1ef7e6a811f

[connor4312]

#122225 (comment) will be fixed #121751. Currently the debugger attaching is entirely asynchronous to tests running, so this can happen. Might be fixed today if I get through my other misc remaining milestone work.

[deepak1556]

@rebornix can you provide the crash dump following these steps https://github.com/microsoft/vscode/wiki/Native-Crash-Issues#creating-and-symbolicating-local-crash-reports

[connor4312]

I hit this on Windows just now,

Renderer process crashed with: {"reason":"crashed","exitCode":-1073741819}

Report: https://memes.peet.io/img/c3fce1de-6761-4bd9-a58c-12d3b59ac47e.dmp

It isn't the 100% repro that Peng has, so it may be different

[deepak1556]

The above is a crash due to this check https://source.chromium.org/chromium/chromium/src/+/master:v8/src/regexp/regexp-stack.cc;l=19. V8 recently added that check to prevent reentrant irregexp, not sure what triggered it in your case. Given the Regexp stack in Peng's post, very likely he is also hitting the same. Would be good to confirm with his crash report when available.

[weinand]

@rebornix I'd like to reproduce this. Could you please provide detailed steps for

"when I debug a unit test in vscode repo through the self host test extension,"