-
Notifications
You must be signed in to change notification settings - Fork 33.8k
Closed
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bugcandidateIssue identified as probable candidate for fixing in the next releaseIssue identified as probable candidate for fixing in the next releaseterminalGeneral terminal issues that don't fall under another labelGeneral terminal issues that don't fall under another labelverifiedVerification succeededVerification succeeded
Milestone
Description
Does this issue occur when all extensions are disabled?: No
- VS Code Version: 1.57.0-insider
- OS Version: win10 19043.985
Steps to Reproduce:
- Open task-provider-sample with insider version
- Add some code to get the terminal name. In
customTaskProvider.ts
, add the following code in the beginning ofopen()
of theCustomBuildTaskTerminal
(line 91)
const terminals = vscode.window.terminals;
const terminalNames: string[] = [];
for (const terminal of terminals) {
terminalNames.push(terminal.name);
}
- Add a breakpoint after this part and start debugging.
- Configure and run task
custombuildscript: 32 incremental
, VS Code will stop at the breakpoint, we can see the current terminal names, in the insider version, it's an empty string (see the red square):
- Reopen task-provider-sample with stable version, follows the steps 2 and 3 above
- Configure and run task
custombuildscript: 32 incremental
, VS Code will stop at the breakpoint, we can see the current terminal names, in the stable version, it's a valid string (see the red square):
Scenario: I'm developing an extension which might use terminal.show()
by filtering the terminal names. If a terminal's name is empty the feature to show the terminal will not work.
akaroml
Metadata
Metadata
Assignees
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bugcandidateIssue identified as probable candidate for fixing in the next releaseIssue identified as probable candidate for fixing in the next releaseterminalGeneral terminal issues that don't fall under another labelGeneral terminal issues that don't fall under another labelverifiedVerification succeededVerification succeeded