Skip to content

Pseudoterminal has invalid name in insider version #125729

@CsCherrYY

Description

@CsCherrYY

Does this issue occur when all extensions are disabled?: No

  • VS Code Version: 1.57.0-insider
  • OS Version: win10 19043.985

Steps to Reproduce:

  1. Open task-provider-sample with insider version
  2. Add some code to get the terminal name. In customTaskProvider.ts, add the following code in the beginning of open() of the CustomBuildTaskTerminal (line 91)
const terminals = vscode.window.terminals;
const terminalNames: string[] = [];
for (const terminal of terminals) {
	terminalNames.push(terminal.name);
}
  1. Add a breakpoint after this part and start debugging.
  2. Configure and run task custombuildscript: 32 incremental, VS Code will stop at the breakpoint, we can see the current terminal names, in the insider version, it's an empty string (see the red square):
    insider
  3. Reopen task-provider-sample with stable version, follows the steps 2 and 3 above
  4. Configure and run task custombuildscript: 32 incremental, VS Code will stop at the breakpoint, we can see the current terminal names, in the stable version, it's a valid string (see the red square):
    stable

Scenario: I'm developing an extension which might use terminal.show() by filtering the terminal names. If a terminal's name is empty the feature to show the terminal will not work.

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bugcandidateIssue identified as probable candidate for fixing in the next releaseterminalGeneral terminal issues that don't fall under another labelverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions