-
Notifications
You must be signed in to change notification settings - Fork 33.8k
Open
Labels
extensionsIssues concerning extensionsIssues concerning extensionsremoteRemote system operations issuesRemote system operations issuesunder-discussionIssue is under discussion for relevance, priority, approachIssue is under discussion for relevance, priority, approach
Description
Does this issue occur when all extensions are disabled?: Yes
- VS Code Version: 1.99
- OS Version: mac
Expectation
When launching a VS Code server with the --install-extension
flag, extensions should immediately be installed from the marketplace.
Actual
Extensions are not installed until a workbench attaches to the server.
Why
I believe due to this change - maybe:
vscode/src/vs/platform/extensionManagement/common/extensionGalleryManifestServiceIpc.ts
Lines 39 to 42 in 6f4092e
override async getExtensionGalleryManifest(): Promise<IExtensionGalleryManifest | null> { | |
await this.barrier.wait(); | |
return this.extensionGalleryManifest ?? null; | |
} |
, the extension installation is blocked until this barrier is opened by setExtensionGalleryManifest
. This won't happen until the workbench is available.
Steps to Reproduce:
- Start code-server with
./code-server --accept-server-license-terms --start-server --host 127.0.0.1 --install-extension joshspicer.touchbarcommandshortcuts
- 🐛
joshspicer.touchbarcommandshortcuts
does not install immediately
See full video demo for more info:
Screen.Recording.2025-04-07.at.4.19.54.PM.mov
Metadata
Metadata
Assignees
Labels
extensionsIssues concerning extensionsIssues concerning extensionsremoteRemote system operations issuesRemote system operations issuesunder-discussionIssue is under discussion for relevance, priority, approachIssue is under discussion for relevance, priority, approach