Skip to content

Interactive playground: "error underline" unclear #40915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BurtHarris opened this issue Dec 28, 2017 · 6 comments · Fixed by #42001
Closed

Interactive playground: "error underline" unclear #40915

BurtHarris opened this issue Dec 28, 2017 · 6 comments · Fixed by #42001
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded workbench-welcome Welcome page issues
Milestone

Comments

@BurtHarris
Copy link

  • VSCode Version: Code 1.19.1 (0759f77, 2017-12-19T09:46:02.926Z)
  • OS Version: Windows_NT ia32 10.0.16299
  • Extensions: Extensions are disabled

Steps to Reproduce:

  1. Help / Interactive Playground

Under heading IntelliSense, the text reads:

... In the below example, position the text cursor in front of the error underline, right after the dot and press Ctrl+Space".

It it unclear what error underline means, I don't see any underline or error.

@vscodebot vscodebot bot added editor editor-core Editor basic functionality labels Dec 28, 2017
@usernamehw
Copy link
Contributor

usernamehw commented Dec 28, 2017

I can reproduce on the 2nd time:

  1. Open playground
  2. Close tab
  3. Open playground
  4. 🐛 No errors shown & IntelliSense not working & rename & code formatting & // ts-check ...

@BurtHarris
Copy link
Author

Yes, opening playground a second time seems to be key to all the problems I was having with it. Thanks.

@serialprimate
Copy link

serialprimate commented Dec 31, 2017

  • VSCode Version: Code - Insiders 1.20.0-insider (f911534, 2017-12-22T06:14:07.615Z)
  • OS Version: Linux x64 4.9.72-1-lts
  • Extensions: none

Also happens every time for me in Interactive Playground with no extensions loaded w/ insiders on linux.

If restarting vscode repeatedly, sometimes syntax highlight also fails.

EDIT: As I continued on down through the document, some other instructions are failing too.

@Tyriar Tyriar added workbench-welcome Welcome page issues and removed editor editor-core Editor basic functionality labels Jan 2, 2018
@martin-podlubny
Copy link

  • VSCode Version: Code 1.19.1 (0759f77, 2017-12-19T09:35:14.671Z)
  • OS Version: Darwin x64 16.7.0
  • Extensions: none

I just got VSCode for the first time, fresh install on macOS, and experienced the same issue with different features in the Interactive Playground described here by the peeps above. Don't have much to add in terms of describing/reproducing the issue, just posting here for completeness that the issue affects 1.19.1 on OSX as well.

@chrmarti chrmarti added this to the December 2017/January 2018 milestone Jan 3, 2018
@chrmarti
Copy link
Collaborator

chrmarti commented Jan 16, 2018

@mjbvz I see this when opening without a folder. The missing errors also reproduce in an untitled file in JavaScript mode (code actions seem to work in this case). Code actions do not work in the interactive playground when the workbench is not open on a folder. Could you take a look?

@mjbvz
Copy link
Collaborator

mjbvz commented Jan 23, 2018

Note that this still requires this upstream fix from TS (microsoft/TypeScript#21338)

@octref octref added the verified Verification succeeded label Feb 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded workbench-welcome Welcome page issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants